Re: [PATCH 4.14 17/89] futex: Prevent overflow by strengthen input validation

2018-01-25 Thread Darren Hart
On Thu, Jan 25, 2018 at 04:21:51PM +0100, Jiri Slaby wrote: > On 01/25/2018, 04:12 PM, Greg Kroah-Hartman wrote: > > On Thu, Jan 25, 2018 at 03:47:32PM +0100, Jiri Slaby wrote: > >> On 01/25/2018, 03:30 PM, Thomas Gleixner wrote: > >>> So what's the problem? > >> > >> The problem I see is that ever

Re: [PATCH 4.14 17/89] futex: Prevent overflow by strengthen input validation

2018-01-25 Thread Peter Zijlstra
On Thu, Jan 25, 2018 at 04:21:51PM +0100, Jiri Slaby wrote: > > The same reason it was applied upstream, it fixes a reported > > issue. > > > > Does that mean that all UBSAN overflow error reports are not valid > > because of how we build the kernel? > > IMO yes, because with the option, signed o

Re: [PATCH 4.14 17/89] futex: Prevent overflow by strengthen input validation

2018-01-25 Thread Jiri Slaby
On 01/25/2018, 04:12 PM, Greg Kroah-Hartman wrote: > On Thu, Jan 25, 2018 at 03:47:32PM +0100, Jiri Slaby wrote: >> On 01/25/2018, 03:30 PM, Thomas Gleixner wrote: >>> So what's the problem? >> >> The problem I see is that every stable kernel now requires updated >> strace with their commit from ye

Re: [PATCH 4.14 17/89] futex: Prevent overflow by strengthen input validation

2018-01-25 Thread Greg Kroah-Hartman
On Thu, Jan 25, 2018 at 03:47:32PM +0100, Jiri Slaby wrote: > On 01/25/2018, 03:30 PM, Thomas Gleixner wrote: > > So what's the problem? > > The problem I see is that every stable kernel now requires updated > strace with their commit from yesterday to build correctly. In > particular, the new sta

Re: [PATCH 4.14 17/89] futex: Prevent overflow by strengthen input validation

2018-01-25 Thread Jiri Slaby
On 01/25/2018, 03:30 PM, Thomas Gleixner wrote: > So what's the problem? The problem I see is that every stable kernel now requires updated strace with their commit from yesterday to build correctly. In particular, the new stable kernels cause rpm build failures of strace in all our distros (based

Re: [PATCH 4.14 17/89] futex: Prevent overflow by strengthen input validation

2018-01-25 Thread Thomas Gleixner
On Thu, 25 Jan 2018, Jiri Slaby wrote: > On 01/25/2018, 03:03 PM, Thomas Gleixner wrote: > > On Thu, 25 Jan 2018, Jiri Slaby wrote: > >> On 01/22/2018, 09:44 AM, Greg Kroah-Hartman wrote: > >>> + if (nr_wake < 0 || nr_requeue < 0) > >>> + return -EINVAL; > >> > >> This breaks strace's test

Re: [PATCH 4.14 17/89] futex: Prevent overflow by strengthen input validation

2018-01-25 Thread Jiri Slaby
On 01/25/2018, 03:03 PM, Thomas Gleixner wrote: > On Thu, 25 Jan 2018, Jiri Slaby wrote: >> On 01/22/2018, 09:44 AM, Greg Kroah-Hartman wrote: >>> + if (nr_wake < 0 || nr_requeue < 0) >>> + return -EINVAL; >> >> This breaks strace's test suite on 4.14.15 (and is present in upstream >> o

Re: [PATCH 4.14 17/89] futex: Prevent overflow by strengthen input validation

2018-01-25 Thread Thomas Gleixner
On Thu, 25 Jan 2018, Jiri Slaby wrote: > On 01/22/2018, 09:44 AM, Greg Kroah-Hartman wrote: > > + if (nr_wake < 0 || nr_requeue < 0) > > + return -EINVAL; > > This breaks strace's test suite on 4.14.15 (and is present in upstream > obviously too): > futex(0x7ff568b44ffc, 0x3, 0xfac

Re: [PATCH 4.14 17/89] futex: Prevent overflow by strengthen input validation

2018-01-25 Thread Jiri Slaby
On 01/22/2018, 09:44 AM, Greg Kroah-Hartman wrote: > 4.14-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Li Jinyue > > commit fbe0e839d1e22d88810f3ee3e2f1479be4c0aa4a upstream. > > UBSAN reports signed integer overflow in kernel/futex.c

[PATCH 4.14 17/89] futex: Prevent overflow by strengthen input validation

2018-01-22 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Li Jinyue commit fbe0e839d1e22d88810f3ee3e2f1479be4c0aa4a upstream. UBSAN reports signed integer overflow in kernel/futex.c: UBSAN: Undefined behaviour in kernel/futex.c:2041:18 signed inte