Re: [PATCH 4.19 01/24] bridge: do not add port to router list when receives query with source 0.0.0.0

2019-02-21 Thread Sebastian Gottschall
Am 20.02.2019 um 15:46 schrieb Hangbin Liu: Could you please include more details about the setup that's broken ? Note that we were warned[1] of potential breakage from this change Sorry I missed Linus's reply after Ying Xu replied. I will read it and disscuss with Ying Xu. after it went in

Re: [PATCH 4.19 01/24] bridge: do not add port to router list when receives query with source 0.0.0.0

2019-02-21 Thread Greg Kroah-Hartman
On Wed, Feb 20, 2019 at 01:48:47PM +0100, Sebastian Gottschall wrote: > *reminder* > > Am 18.02.2019 um 11:18 schrieb Sebastian Gottschall: > > > > Am 17.02.2019 um 17:48 schrieb Greg Kroah-Hartman: > > > On Sun, Feb 17, 2019 at 03:29:22PM +0100, Sebastian Gottschall wrote: > > > > according to

Re: [PATCH 4.19 01/24] bridge: do not add port to router list when receives query with source 0.0.0.0

2019-02-20 Thread Hangbin Liu
On Wed, Feb 20, 2019 at 03:09:21PM +0200, Nikolay Aleksandrov wrote: > On 20/02/2019 14:48, Sebastian Gottschall wrote: > > *reminder* > > > [snip] > >    } > >    static void br_ip4_multicast_query(struct net_bridge *br, > >>> Is this also a problem in 4.20?  This patch went into

Re: [PATCH 4.19 01/24] bridge: do not add port to router list when receives query with source 0.0.0.0

2019-02-20 Thread Nikolay Aleksandrov
On 20/02/2019 15:09, Nikolay Aleksandrov wrote: > On 20/02/2019 14:48, Sebastian Gottschall wrote: >> *reminder* >> > [snip] >>    } >>    static void br_ip4_multicast_query(struct net_bridge *br, Is this also a problem in 4.20?  This patch went into 4.20-rc1, so it has been

Re: [PATCH 4.19 01/24] bridge: do not add port to router list when receives query with source 0.0.0.0

2019-02-20 Thread Nikolay Aleksandrov
On 20/02/2019 14:48, Sebastian Gottschall wrote: > *reminder* > [snip] >    } >    static void br_ip4_multicast_query(struct net_bridge *br, >>> Is this also a problem in 4.20?  This patch went into 4.20-rc1, so it >>> has been around for a while with no reported issues that I can find.

Re: [PATCH 4.19 01/24] bridge: do not add port to router list when receives query with source 0.0.0.0

2019-02-20 Thread Sebastian Gottschall
*reminder* Am 18.02.2019 um 11:18 schrieb Sebastian Gottschall: Am 17.02.2019 um 17:48 schrieb Greg Kroah-Hartman: On Sun, Feb 17, 2019 at 03:29:22PM +0100, Sebastian Gottschall wrote: according to user reports this patch will cause a serious regression. igmp snooping is not working anymore

Re: [PATCH 4.19 01/24] bridge: do not add port to router list when receives query with source 0.0.0.0

2019-02-18 Thread Sebastian Gottschall
Am 17.02.2019 um 17:48 schrieb Greg Kroah-Hartman: On Sun, Feb 17, 2019 at 03:29:22PM +0100, Sebastian Gottschall wrote: according to user reports this patch will cause a serious regression. igmp snooping is not working anymore with this patch Am 02.11.2018 um 19:34 schrieb Greg

Re: [PATCH 4.19 01/24] bridge: do not add port to router list when receives query with source 0.0.0.0

2019-02-17 Thread Greg Kroah-Hartman
On Sun, Feb 17, 2019 at 03:29:22PM +0100, Sebastian Gottschall wrote: > according to user reports this patch will cause a serious regression. igmp > snooping is not working anymore with this patch > > Am 02.11.2018 um 19:34 schrieb Greg Kroah-Hartman: > > 4.19-stable review patch. If anyone has

Re: [PATCH 4.19 01/24] bridge: do not add port to router list when receives query with source 0.0.0.0

2019-02-17 Thread Sebastian Gottschall
according to user reports this patch will cause a serious regression. igmp snooping is not working anymore with this patch Am 02.11.2018 um 19:34 schrieb Greg Kroah-Hartman: 4.19-stable review patch. If anyone has any objections, please let me know. -- From: Hangbin Liu [

[PATCH 4.19 01/24] bridge: do not add port to router list when receives query with source 0.0.0.0

2018-11-02 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- From: Hangbin Liu [ Upstream commit 5a2de63fd1a59c30c02526d427bc014b98adf508 ] Based on RFC 4541, 2.1.1. IGMP Forwarding Rules The switch supporting IGMP snooping must maintain a list of

[PATCH 4.19 01/24] bridge: do not add port to router list when receives query with source 0.0.0.0

2018-11-02 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- From: Hangbin Liu [ Upstream commit 5a2de63fd1a59c30c02526d427bc014b98adf508 ] Based on RFC 4541, 2.1.1. IGMP Forwarding Rules The switch supporting IGMP snooping must maintain a list of