Re: [PATCH 5/5] pinctrl: rockchip: correctly handle arguments of pinconf options

2013-06-16 Thread Linus Walleij
On Sun, Jun 16, 2013 at 1:02 PM, Heiko Stübner wrote: >> > - *config = 0; >> > + pull = rockchip_get_pull(bank, pin - bank->pin_base); >> > + *config = (pull == param) ? 1 : 0; >> >> And then I guess you should emit PIN_CONFIG_BIAS_DISABLE >> here as well

Re: [PATCH 5/5] pinctrl: rockchip: correctly handle arguments of pinconf options

2013-06-16 Thread Heiko Stübner
Am Sonntag, 16. Juni 2013, 12:35:43 schrieb Linus Walleij: > On Fri, Jun 14, 2013 at 5:44 PM, Heiko Stübner wrote: > > Change the rockchip pinctrl driver to handle the arguments of 0 or 1 to > > the pull pinconfig options correctly, so that the pull gets disabled when > > either the bias_disable o

Re: [PATCH 5/5] pinctrl: rockchip: correctly handle arguments of pinconf options

2013-06-16 Thread Linus Walleij
On Fri, Jun 14, 2013 at 5:44 PM, Heiko Stübner wrote: > Change the rockchip pinctrl driver to handle the arguments of 0 or 1 to > the pull pinconfig options correctly, so that the pull gets disabled when > either the bias_disable options is set or the pull option has the argument 0. > > Signed-of

[PATCH 5/5] pinctrl: rockchip: correctly handle arguments of pinconf options

2013-06-14 Thread Heiko Stübner
Change the rockchip pinctrl driver to handle the arguments of 0 or 1 to the pull pinconfig options correctly, so that the pull gets disabled when either the bias_disable options is set or the pull option has the argument 0. Signed-off-by: Heiko Stuebner --- drivers/pinctrl/pinctrl-rockchip.c |