Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-29 Thread Daniel Baluta
On Mon, Jul 29, 2019 at 10:49 AM Anson Huang wrote: > > We are all set then. Thanks Anson for clarifications! > > Thanks, so we are all clear about this issue, need to wait thermal maintainer > to review > the rest patch in this series, but I did NOT receive any response from > thermal

RE: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-29 Thread Anson Huang
Hi, Daniel > On Mon, Jul 29, 2019 at 10:20 AM Daniel Baluta > wrote: > > > > > > > > Your explanation makes a lot of sense. We will take care today of > > > > Abel's patch. > > > > What do you think about Fabio's patch? I also think this is a valid > > > > patch: > > > > > > > > > > > > > >

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-29 Thread Daniel Baluta
On Mon, Jul 29, 2019 at 10:20 AM Daniel Baluta wrote: > > > > > Your explanation makes a lot of sense. We will take care today of Abel's > > > patch. > > > What do you think about Fabio's patch? I also think this is a valid patch: > > > > > > > > > Hmm, when did Fabio sent out this patch? I can

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-29 Thread Daniel Baluta
> > Your explanation makes a lot of sense. We will take care today of Abel's > > patch. > > What do you think about Fabio's patch? I also think this is a valid patch: > > > > Hmm, when did Fabio sent out this patch? I can NOT find it... > I also have a patch in this series (#4/6) doing same

RE: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-29 Thread Anson Huang
t; > > > > Hi, Daniel > > > > > > > > > > > Subject: Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL > > > > > > flag for IMX8MQ_CLK_TMU_ROOT > > > > > > > > > > > > Hi all, > > > > > &

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-29 Thread Daniel Baluta
On Mon, Jul 29, 2019 at 4:29 AM Anson Huang wrote: > > Hi, Abel/Daniel > > > On 19-07-27 09:33:10, Daniel Baluta wrote: > > > On Sat, Jul 27, 2019 at 9:19 AM Anson Huang > > wrote: > > > > > > > > Hi, Daniel > > > > > >

RE: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-28 Thread Anson Huang
Hi, Abel/Daniel > On 19-07-27 09:33:10, Daniel Baluta wrote: > > On Sat, Jul 27, 2019 at 9:19 AM Anson Huang > wrote: > > > > > > Hi, Daniel > > > > > > > Subject: Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag >

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-28 Thread Fabio Estevam
Hi Guido, On Sun, Jul 28, 2019 at 4:59 AM Guido Günther wrote: > Yes, this fixes it for me, thanks! Thanks for testing it. I will send a formal patch tomorrow. Regards, Fabio Estevam

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-28 Thread Guido Günther
Hi Fabio, On Sat, Jul 27, 2019 at 05:17:50PM -0300, Fabio Estevam wrote: > Hi Guido, > > On Sat, Jul 27, 2019 at 3:26 PM Guido Günther wrote: > > > I noticed a boot hang yesterday on next-20190726 when loading the > > qoriq_thermal which I worked around by blacklisting it. The > >

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-27 Thread Fabio Estevam
Hi Guido, On Sat, Jul 27, 2019 at 3:26 PM Guido Günther wrote: > I noticed a boot hang yesterday on next-20190726 when loading the > qoriq_thermal which I worked around by blacklisting it. The > fsl,imx8mq-tmu node specifies a clock (IMX8MQ_CLK_TMU_ROOT) but does not > seem to enable, shouldn't

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-27 Thread Guido Günther
Hi Daniel, On Sat, Jul 27, 2019 at 01:26:50AM +0300, Daniel Baluta wrote: > Hi all, > > latest linux-next hangs at boot. > > commit fde50b96be821ac9673a7e00847cc4605bd88f34 (HEAD -> master, tag: > next-20190726, origin/master, origin/HEAD) > Author: Stephen Rothwell > Date: Fri Jul 26

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-27 Thread Abel Vesa
On 19-07-27 09:33:10, Daniel Baluta wrote: > On Sat, Jul 27, 2019 at 9:19 AM Anson Huang wrote: > > > > Hi, Daniel > > > > > Subject: Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for > > > IMX8MQ_CLK_TMU_ROOT > > > > >

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-27 Thread Daniel Baluta
On Sat, Jul 27, 2019 at 9:19 AM Anson Huang wrote: > > Hi, Daniel > > > Subject: Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for > > IMX8MQ_CLK_TMU_ROOT > > > > Hi all, > > > > latest linux-next hangs at boot. > > > > commit

RE: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-27 Thread Anson Huang
Hi, Daniel > Subject: Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for > IMX8MQ_CLK_TMU_ROOT > > Hi all, > > latest linux-next hangs at boot. > > commit fde50b96be821ac9673a7e00847cc4605bd88f34 (HEAD -> master, tag: > next-20190726, origin/master,

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-26 Thread Daniel Baluta
Hi all, latest linux-next hangs at boot. commit fde50b96be821ac9673a7e00847cc4605bd88f34 (HEAD -> master, tag: next-20190726, origin/master, origin/HEAD) Author: Stephen Rothwell Date: Fri Jul 26 15:18:02 2019 +1000 Add linux-next specific files for 20190726 Signed-off-by: Stephen

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-22 Thread Shawn Guo
On Fri, Jul 05, 2019 at 12:56:11PM +0800, anson.hu...@nxp.com wrote: > From: Anson Huang > > IMX8MQ_CLK_TMU_ROOT is ONLY used for thermal module, the driver > should manage this clock, so no need to have CLK_IS_CRITICAL flag > set. > > Signed-off-by: Anson Huang Applied, thanks.

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-22 Thread Stephen Boyd
Quoting anson.hu...@nxp.com (2019-07-04 21:56:11) > From: Anson Huang > > IMX8MQ_CLK_TMU_ROOT is ONLY used for thermal module, the driver > should manage this clock, so no need to have CLK_IS_CRITICAL flag > set. > > Signed-off-by: Anson Huang > --- Acked-by: Stephen Boyd

Re: [PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-05 Thread Abel Vesa
On 19-07-05 12:56:11, anson.hu...@nxp.com wrote: > From: Anson Huang > > IMX8MQ_CLK_TMU_ROOT is ONLY used for thermal module, the driver > should manage this clock, so no need to have CLK_IS_CRITICAL flag > set. > > Signed-off-by: Anson Huang Reviewed-by: Abel Vesa > --- >

[PATCH 5/6] clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT

2019-07-04 Thread Anson . Huang
From: Anson Huang IMX8MQ_CLK_TMU_ROOT is ONLY used for thermal module, the driver should manage this clock, so no need to have CLK_IS_CRITICAL flag set. Signed-off-by: Anson Huang --- drivers/clk/imx/clk-imx8mq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git