Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-06-05 Thread Johannes Weiner
On Sat, Jun 03, 2017 at 08:50:02PM +0300, Vladimir Davydov wrote: > On Tue, May 30, 2017 at 02:17:23PM -0400, Johannes Weiner wrote: > > lruvecs are at the intersection of the NUMA node and memcg, which is > > the scope for most paging activity. > > > > Introduce a convenient accounting

Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-06-05 Thread Johannes Weiner
On Sat, Jun 03, 2017 at 08:50:02PM +0300, Vladimir Davydov wrote: > On Tue, May 30, 2017 at 02:17:23PM -0400, Johannes Weiner wrote: > > lruvecs are at the intersection of the NUMA node and memcg, which is > > the scope for most paging activity. > > > > Introduce a convenient accounting

Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-06-03 Thread Vladimir Davydov
On Tue, May 30, 2017 at 02:17:23PM -0400, Johannes Weiner wrote: > lruvecs are at the intersection of the NUMA node and memcg, which is > the scope for most paging activity. > > Introduce a convenient accounting infrastructure that maintains > statistics per node, per memcg, and the lruvec

Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-06-03 Thread Vladimir Davydov
On Tue, May 30, 2017 at 02:17:23PM -0400, Johannes Weiner wrote: > lruvecs are at the intersection of the NUMA node and memcg, which is > the scope for most paging activity. > > Introduce a convenient accounting infrastructure that maintains > statistics per node, per memcg, and the lruvec

Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-05-31 Thread Johannes Weiner
On Wed, May 31, 2017 at 11:18:21AM -0700, Andrew Morton wrote: > On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner wrote: > > > Andrew, the 0day tester found a crash with this when special pages get > > faulted. They're not charged to any cgroup and we'll deref NULL. > > >

Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-05-31 Thread Johannes Weiner
On Wed, May 31, 2017 at 11:18:21AM -0700, Andrew Morton wrote: > On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner wrote: > > > Andrew, the 0day tester found a crash with this when special pages get > > faulted. They're not charged to any cgroup and we'll deref NULL. > > > > Can you include

Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-05-31 Thread Stephen Rothwell
Hi Tony, Andrew, On Wed, 31 May 2017 12:02:10 -0700 Tony Lindgren wrote: > > * Andrew Morton [170531 11:21]: > > On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner > > wrote: > > > > > Andrew, the 0day tester found a crash

Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-05-31 Thread Stephen Rothwell
Hi Tony, Andrew, On Wed, 31 May 2017 12:02:10 -0700 Tony Lindgren wrote: > > * Andrew Morton [170531 11:21]: > > On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner > > wrote: > > > > > Andrew, the 0day tester found a crash with this when special pages get > > > faulted. They're not charged

Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-05-31 Thread Tony Lindgren
* Andrew Morton [170531 11:21]: > On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner wrote: > > > Andrew, the 0day tester found a crash with this when special pages get > > faulted. They're not charged to any cgroup and we'll deref NULL. > > > >

Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-05-31 Thread Tony Lindgren
* Andrew Morton [170531 11:21]: > On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner wrote: > > > Andrew, the 0day tester found a crash with this when special pages get > > faulted. They're not charged to any cgroup and we'll deref NULL. > > > > Can you include the following fix on top of this

Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-05-31 Thread Andrew Morton
On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner wrote: > Andrew, the 0day tester found a crash with this when special pages get > faulted. They're not charged to any cgroup and we'll deref NULL. > > Can you include the following fix on top of this patch please? Thanks!

Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-05-31 Thread Andrew Morton
On Wed, 31 May 2017 13:14:50 -0400 Johannes Weiner wrote: > Andrew, the 0day tester found a crash with this when special pages get > faulted. They're not charged to any cgroup and we'll deref NULL. > > Can you include the following fix on top of this patch please? Thanks! OK. But this won't

Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-05-31 Thread Johannes Weiner
Andrew, the 0day tester found a crash with this when special pages get faulted. They're not charged to any cgroup and we'll deref NULL. Can you include the following fix on top of this patch please? Thanks! --- >From 0ea9bdb1b425a6c943a65c02164d4ca51815fdc4 Mon Sep 17 00:00:00 2001 From:

Re: [PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-05-31 Thread Johannes Weiner
Andrew, the 0day tester found a crash with this when special pages get faulted. They're not charged to any cgroup and we'll deref NULL. Can you include the following fix on top of this patch please? Thanks! --- >From 0ea9bdb1b425a6c943a65c02164d4ca51815fdc4 Mon Sep 17 00:00:00 2001 From:

[PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-05-30 Thread Johannes Weiner
lruvecs are at the intersection of the NUMA node and memcg, which is the scope for most paging activity. Introduce a convenient accounting infrastructure that maintains statistics per node, per memcg, and the lruvec itself. Then convert over accounting sites for statistics that are already

[PATCH 5/6] mm: memcontrol: per-lruvec stats infrastructure

2017-05-30 Thread Johannes Weiner
lruvecs are at the intersection of the NUMA node and memcg, which is the scope for most paging activity. Introduce a convenient accounting infrastructure that maintains statistics per node, per memcg, and the lruvec itself. Then convert over accounting sites for statistics that are already