> > > utask->vaddr = bp_vaddr;
> > >
> > > - return arch_uprobe_pre_xol(&uprobe->arch, regs);
> > > + err = arch_uprobe_pre_xol(&uprobe->arch, regs);
> > > + if (unlikely(err)) {
> > > + xol_free_insn_slot(current);
> > > + return err;
> > > + }
> > > +
> > > + return 0;
> > > }
On 01/08, Srikar Dronamraju wrote:
>
> * Oleg Nesterov [2012-12-31 18:52:26]:
>
> > pre_ssout() should do xol_free_insn_slot() if arch_uprobe_pre_xol()
> > fails, otherwise nobody will free the allocated slot.
> >
> > Signed-off-by: Oleg Nesterov
>
> Acked-by: Srikar Dronamraju
Thanks!
> (one
* Oleg Nesterov [2012-12-31 18:52:26]:
> pre_ssout() should do xol_free_insn_slot() if arch_uprobe_pre_xol()
> fails, otherwise nobody will free the allocated slot.
>
> Signed-off-by: Oleg Nesterov
Acked-by: Srikar Dronamraju
(one nit below)
> ---
> kernel/events/uprobes.c |9 -
pre_ssout() should do xol_free_insn_slot() if arch_uprobe_pre_xol()
fails, otherwise nobody will free the allocated slot.
Signed-off-by: Oleg Nesterov
---
kernel/events/uprobes.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/kernel/events/uprobes.c b/kernel/eve
4 matches
Mail list logo
