Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

On 24/11/16 15:34, Ulf Hansson wrote: > On 24 November 2016 at 13:41, Ziji Hu wrote: >> On 2016/11/24 18:43, Ulf Hansson wrote: >>> On 31 October 2016 at 12:09, Gregory CLEMENT >>> wrote: From: Ziji Hu +static

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

On 24/11/16 15:34, Ulf Hansson wrote: > On 24 November 2016 at 13:41, Ziji Hu wrote: >> On 2016/11/24 18:43, Ulf Hansson wrote: >>> On 31 October 2016 at 12:09, Gregory CLEMENT >>> wrote: From: Ziji Hu +static int xenon_start_signal_voltage_switch(struct mmc_host *mmc, +

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Ulf, On 2016/11/25 21:06, Ulf Hansson wrote: > [...] > >>> + >>> + /* >>> +* Xenon Specific property: >>> +* emmc: explicitly indicate whether this slot is for eMMC >>> +* slotno: the index of slot. Refer to SDHC_SYS_CFG_INFO >>> register

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Ulf, On 2016/11/25 21:06, Ulf Hansson wrote: > [...] > >>> + >>> + /* >>> +* Xenon Specific property: >>> +* emmc: explicitly indicate whether this slot is for eMMC >>> +* slotno: the index of slot. Refer to SDHC_SYS_CFG_INFO >>> register

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

[...] >> + >> + /* >> +* Xenon Specific property: >> +* emmc: explicitly indicate whether this slot is for eMMC >> +* slotno: the index of slot. Refer to SDHC_SYS_CFG_INFO register >> +* tun-count: the interval between re-tuning >>

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

[...] >> + >> + /* >> +* Xenon Specific property: >> +* emmc: explicitly indicate whether this slot is for eMMC >> +* slotno: the index of slot. Refer to SDHC_SYS_CFG_INFO register >> +* tun-count: the interval between re-tuning >>

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

[...] >> >> Moreover, we have ->enable_sdio_irq() ops that deals with this. >> >Yes. I mean the SDIO irqs on DAT1 line in async mode. >This field enables our host to recognize the async SDIO irq from SDIO > device. >It controls our host side behavior, other than the SDIO device. > >

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

[...] >> >> Moreover, we have ->enable_sdio_irq() ops that deals with this. >> >Yes. I mean the SDIO irqs on DAT1 line in async mode. >This field enables our host to recognize the async SDIO irq from SDIO > device. >It controls our host side behavior, other than the SDIO device. > >

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Ulf, On 2016/11/24 23:00, Ziji Hu wrote: > Hi Ulf, > > On 2016/11/24 21:34, Ulf Hansson wrote: > + > + /* > +* Xenon Specific property: > +* emmc: explicitly indicate whether this slot is for eMMC > +* slotno: the index of slot. Refer to

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Ulf, On 2016/11/24 23:00, Ziji Hu wrote: > Hi Ulf, > > On 2016/11/24 21:34, Ulf Hansson wrote: > + > + /* > +* Xenon Specific property: > +* emmc: explicitly indicate whether this slot is for eMMC > +* slotno: the index of slot. Refer to

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Ulf, On 2016/11/24 21:34, Ulf Hansson wrote: > On 24 November 2016 at 13:41, Ziji Hu wrote: >> Hi Ulf, >> >> On 2016/11/24 18:43, Ulf Hansson wrote: >>> On 31 October 2016 at 12:09, Gregory CLEMENT >>> wrote: From: Ziji Hu

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Ulf, On 2016/11/24 21:34, Ulf Hansson wrote: > On 24 November 2016 at 13:41, Ziji Hu wrote: >> Hi Ulf, >> >> On 2016/11/24 18:43, Ulf Hansson wrote: >>> On 31 October 2016 at 12:09, Gregory CLEMENT >>> wrote: From: Ziji Hu >> +static int

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

On 24 November 2016 at 13:41, Ziji Hu wrote: > Hi Ulf, > > On 2016/11/24 18:43, Ulf Hansson wrote: >> On 31 October 2016 at 12:09, Gregory CLEMENT >> wrote: >>> From: Ziji Hu >>> > >>> +static int

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

On 24 November 2016 at 13:41, Ziji Hu wrote: > Hi Ulf, > > On 2016/11/24 18:43, Ulf Hansson wrote: >> On 31 October 2016 at 12:09, Gregory CLEMENT >> wrote: >>> From: Ziji Hu >>> > >>> +static int xenon_emmc_signal_voltage_switch(struct mmc_host *mmc, >>> +

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Ulf, On 2016/11/24 18:43, Ulf Hansson wrote: > On 31 October 2016 at 12:09, Gregory CLEMENT > wrote: >> From: Ziji Hu >> >> +static int xenon_emmc_signal_voltage_switch(struct mmc_host *mmc, >> +

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Ulf, On 2016/11/24 18:43, Ulf Hansson wrote: > On 31 October 2016 at 12:09, Gregory CLEMENT > wrote: >> From: Ziji Hu >> >> +static int xenon_emmc_signal_voltage_switch(struct mmc_host *mmc, >> + struct mmc_ios *ios) >> +{ >> + unsigned char

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

On 31 October 2016 at 12:09, Gregory CLEMENT wrote: > From: Ziji Hu > > Add Xenon eMMC/SD/SDIO host controller core functionality. > Add Xenon specific intialization process. > Add Xenon specific mmc_host_ops APIs. > Add Xenon specific

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

On 31 October 2016 at 12:09, Gregory CLEMENT wrote: > From: Ziji Hu > > Add Xenon eMMC/SD/SDIO host controller core functionality. > Add Xenon specific intialization process. > Add Xenon specific mmc_host_ops APIs. > Add Xenon specific register definitions. > > Add CONFIG_MMC_SDHCI_XENON support

[PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

From: Ziji Hu Add Xenon eMMC/SD/SDIO host controller core functionality. Add Xenon specific intialization process. Add Xenon specific mmc_host_ops APIs. Add Xenon specific register definitions. Add CONFIG_MMC_SDHCI_XENON support in drivers/mmc/host/Kconfig. Marvell Xenon

[PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

From: Ziji Hu Add Xenon eMMC/SD/SDIO host controller core functionality. Add Xenon specific intialization process. Add Xenon specific mmc_host_ops APIs. Add Xenon specific register definitions. Add CONFIG_MMC_SDHCI_XENON support in drivers/mmc/host/Kconfig. Marvell Xenon SDHC conforms to SD

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Adrian, On 2016/10/17 16:14, Adrian Hunter wrote: > On 13/10/16 08:38, Ziji Hu wrote: >> Hi Adrian, >> >> On 2016/10/12 21:07, Adrian Hunter wrote: >>> On 12/10/16 14:58, Ziji Hu wrote: Hi Adrian, Thank you very much for your review. I will firstly fix the typo.

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Adrian, On 2016/10/17 16:14, Adrian Hunter wrote: > On 13/10/16 08:38, Ziji Hu wrote: >> Hi Adrian, >> >> On 2016/10/12 21:07, Adrian Hunter wrote: >>> On 12/10/16 14:58, Ziji Hu wrote: Hi Adrian, Thank you very much for your review. I will firstly fix the typo.

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

On 13/10/16 08:38, Ziji Hu wrote: > Hi Adrian, > > On 2016/10/12 21:07, Adrian Hunter wrote: >> On 12/10/16 14:58, Ziji Hu wrote: >>> Hi Adrian, >>> >>> Thank you very much for your review. >>> I will firstly fix the typo. >>> >>> On 2016/10/11 20:37, Adrian Hunter wrote: > > + >

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

On 13/10/16 08:38, Ziji Hu wrote: > Hi Adrian, > > On 2016/10/12 21:07, Adrian Hunter wrote: >> On 12/10/16 14:58, Ziji Hu wrote: >>> Hi Adrian, >>> >>> Thank you very much for your review. >>> I will firstly fix the typo. >>> >>> On 2016/10/11 20:37, Adrian Hunter wrote: > > + >

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Adrian, On 2016/10/12 21:07, Adrian Hunter wrote: > On 12/10/16 14:58, Ziji Hu wrote: >> Hi Adrian, >> >> Thank you very much for your review. >> I will firstly fix the typo. >> >> On 2016/10/11 20:37, Adrian Hunter wrote: + +static int

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Adrian, On 2016/10/12 21:07, Adrian Hunter wrote: > On 12/10/16 14:58, Ziji Hu wrote: >> Hi Adrian, >> >> Thank you very much for your review. >> I will firstly fix the typo. >> >> On 2016/10/11 20:37, Adrian Hunter wrote: + +static int

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

On 12/10/16 14:58, Ziji Hu wrote: > Hi Adrian, > > Thank you very much for your review. > I will firstly fix the typo. > > On 2016/10/11 20:37, Adrian Hunter wrote: >> On 07/10/16 18:22, Gregory CLEMENT wrote: >>> From: Ziji Hu >>> >>> Add Xenon eMMC/SD/SDIO host

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

On 12/10/16 14:58, Ziji Hu wrote: > Hi Adrian, > > Thank you very much for your review. > I will firstly fix the typo. > > On 2016/10/11 20:37, Adrian Hunter wrote: >> On 07/10/16 18:22, Gregory CLEMENT wrote: >>> From: Ziji Hu >>> >>> Add Xenon eMMC/SD/SDIO host controller core

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Adrian, Thank you very much for your review. I will firstly fix the typo. On 2016/10/11 20:37, Adrian Hunter wrote: > On 07/10/16 18:22, Gregory CLEMENT wrote: >> From: Ziji Hu >> >> Add Xenon eMMC/SD/SDIO host controller core functionality. >> Add Xenon

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

Hi Adrian, Thank you very much for your review. I will firstly fix the typo. On 2016/10/11 20:37, Adrian Hunter wrote: > On 07/10/16 18:22, Gregory CLEMENT wrote: >> From: Ziji Hu >> >> Add Xenon eMMC/SD/SDIO host controller core functionality. >> Add Xenon specific

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

On 07/10/16 18:22, Gregory CLEMENT wrote: > From: Ziji Hu > > Add Xenon eMMC/SD/SDIO host controller core functionality. > Add Xenon specific intialization process. > Add Xenon specific mmc_host_ops APIs. > Add Xenon specific register definitions. > > Add

Re: [PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

On 07/10/16 18:22, Gregory CLEMENT wrote: > From: Ziji Hu > > Add Xenon eMMC/SD/SDIO host controller core functionality. > Add Xenon specific intialization process. > Add Xenon specific mmc_host_ops APIs. > Add Xenon specific register definitions. > > Add CONFIG_MMC_SDHCI_XENON support in

[PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

From: Ziji Hu Add Xenon eMMC/SD/SDIO host controller core functionality. Add Xenon specific intialization process. Add Xenon specific mmc_host_ops APIs. Add Xenon specific register definitions. Add CONFIG_MMC_SDHCI_XENON support in drivers/mmc/host/Kconfig. Marvell Xenon

[PATCH 6/10] mmc: sdhci-xenon: Add Marvell Xenon SDHC core functionality

From: Ziji Hu Add Xenon eMMC/SD/SDIO host controller core functionality. Add Xenon specific intialization process. Add Xenon specific mmc_host_ops APIs. Add Xenon specific register definitions. Add CONFIG_MMC_SDHCI_XENON support in drivers/mmc/host/Kconfig. Marvell Xenon SDHC conforms to SD