Re: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie

2017-04-12 Thread Mark Brown
On Wed, Apr 12, 2017 at 06:11:54PM +0200, Lucas Stach wrote: > Am Donnerstag, den 13.04.2017, 15:41 +0800 schrieb Dong Aisheng: > > The default voltage 1.100v this patch sets is defined in reference > > manual. > Huh? Shouldn't regulator_enable bring the voltage in a range defined by > the constr

Re: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie

2017-04-12 Thread Lucas Stach
Am Donnerstag, den 13.04.2017, 15:41 +0800 schrieb Dong Aisheng: > On Tue, Apr 11, 2017 at 09:40:03PM +0100, Mark Brown wrote: > > On Wed, Apr 12, 2017 at 09:58:47AM +0800, Dong Aisheng wrote: > > > Set the initial voltage selector for vddpcie in case it's disabled > > > by default. > > > > Why is

Re: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie

2017-04-12 Thread Dong Aisheng
On Wed, Apr 12, 2017 at 11:49 PM, Mark Brown wrote: > On Thu, Apr 13, 2017 at 03:41:03PM +0800, Dong Aisheng wrote: >> On Tue, Apr 11, 2017 at 09:40:03PM +0100, Mark Brown wrote: > >> > Why is this the only anatop regulator which can have this problem and >> > how do we know this is a good value?

Re: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie

2017-04-12 Thread Mark Brown
On Thu, Apr 13, 2017 at 03:41:03PM +0800, Dong Aisheng wrote: > On Tue, Apr 11, 2017 at 09:40:03PM +0100, Mark Brown wrote: > > Why is this the only anatop regulator which can have this problem and > > how do we know this is a good value? > Anatop regulator has no separate gate bit. > e.g. >

Re: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie

2017-04-12 Thread Dong Aisheng
On Tue, Apr 11, 2017 at 09:40:03PM +0100, Mark Brown wrote: > On Wed, Apr 12, 2017 at 09:58:47AM +0800, Dong Aisheng wrote: > > Set the initial voltage selector for vddpcie in case it's disabled > > by default. > > Why is this the only anatop regulator which can have this problem and > how do we k

Re: [PATCH 6/6] regulator: anatop: set default voltage selector for pcie

2017-04-11 Thread Mark Brown
On Wed, Apr 12, 2017 at 09:58:47AM +0800, Dong Aisheng wrote: > Set the initial voltage selector for vddpcie in case it's disabled > by default. Why is this the only anatop regulator which can have this problem and how do we know this is a good value? signature.asc Description: PGP signature

[PATCH 6/6] regulator: anatop: set default voltage selector for pcie

2017-04-11 Thread Dong Aisheng
Set the initial voltage selector for vddpcie in case it's disabled by default. This fixes the below warning: 20c8000.anatop:regulator-vddpcie: Failed to read a valid default voltage selector. anatop_regulator: probe of 20c8000.anatop:regulator-vddpcie failed with error -22 Cc: Liam Girdwood Cc