Re: [PATCH 6/6 v6] cpufreq, highbank: add support for highbank cpufreq

2012-11-28 Thread Mike Turquette
Quoting Shawn Guo (2012-11-28 17:51:36) > > The notifiers in the clk framework might be a better place for this than > > just simply hacking the logic into the .set_rate callback. > > Ah, right. How did I forget about that nice piece? > > > I haven't looked at the definition of hb_voltage_change

Re: [PATCH 6/6 v6] cpufreq, highbank: add support for highbank cpufreq

2012-11-28 Thread Shawn Guo
> The notifiers in the clk framework might be a better place for this than > just simply hacking the logic into the .set_rate callback. Ah, right. How did I forget about that nice piece? > I haven't looked at the definition of hb_voltage_change but does the > call graph make any clk api calls?

Re: [PATCH 6/6 v6] cpufreq, highbank: add support for highbank cpufreq

2012-11-28 Thread Mark Langsdorf
On 11/28/2012 03:05 PM, Mike Turquette wrote: > Quoting Mark Langsdorf (2012-11-28 08:18:35) >> On 11/28/2012 10:01 AM, Mike Turquette wrote: >>> Quoting Shawn Guo (2012-11-28 07:17:44) On Wed, Nov 28, 2012 at 10:58:02PM +0800, Shawn Guo wrote: > On Wed, Nov 28, 2012 at 07:16:12AM -0600, M

Re: [PATCH 6/6 v6] cpufreq, highbank: add support for highbank cpufreq

2012-11-28 Thread Mike Turquette
Quoting Mark Langsdorf (2012-11-28 08:18:35) > On 11/28/2012 10:01 AM, Mike Turquette wrote: > > Quoting Shawn Guo (2012-11-28 07:17:44) > >> On Wed, Nov 28, 2012 at 10:58:02PM +0800, Shawn Guo wrote: > >>> On Wed, Nov 28, 2012 at 07:16:12AM -0600, Mark Langsdorf wrote: > I'd > have to mo

Re: [PATCH 6/6 v6] cpufreq, highbank: add support for highbank cpufreq

2012-11-28 Thread Mark Langsdorf
On 11/28/2012 10:01 AM, Mike Turquette wrote: > Quoting Shawn Guo (2012-11-28 07:17:44) >> On Wed, Nov 28, 2012 at 10:58:02PM +0800, Shawn Guo wrote: >>> On Wed, Nov 28, 2012 at 07:16:12AM -0600, Mark Langsdorf wrote: I'd have to move most of the logic of hb_set_target() into clk_hig

Re: [PATCH 6/6 v6] cpufreq, highbank: add support for highbank cpufreq

2012-11-28 Thread Mike Turquette
Quoting Shawn Guo (2012-11-28 07:17:44) > On Wed, Nov 28, 2012 at 10:58:02PM +0800, Shawn Guo wrote: > > On Wed, Nov 28, 2012 at 07:16:12AM -0600, Mark Langsdorf wrote: > > > I'd > > > have to move most of the logic of hb_set_target() into > > > clk_highbank.c:clk_pll_set_rate() and then add extra

Re: [PATCH 6/6 v6] cpufreq, highbank: add support for highbank cpufreq

2012-11-28 Thread Mark Langsdorf
On 11/28/2012 09:17 AM, Shawn Guo wrote: > On Wed, Nov 28, 2012 at 10:58:02PM +0800, Shawn Guo wrote: >> On Wed, Nov 28, 2012 at 07:16:12AM -0600, Mark Langsdorf wrote: >>> I'd >>> have to move most of the logic of hb_set_target() into >>> clk_highbank.c:clk_pll_set_rate() and then add extra logic

Re: [PATCH 6/6 v6] cpufreq, highbank: add support for highbank cpufreq

2012-11-28 Thread Shawn Guo
On Wed, Nov 28, 2012 at 10:58:02PM +0800, Shawn Guo wrote: > On Wed, Nov 28, 2012 at 07:16:12AM -0600, Mark Langsdorf wrote: > > I'd > > have to move most of the logic of hb_set_target() into > > clk_highbank.c:clk_pll_set_rate() and then add extra logic for when > > cpufreq is not enabled/loaded.

Re: [PATCH 6/6 v6] cpufreq, highbank: add support for highbank cpufreq

2012-11-28 Thread Shawn Guo
On Wed, Nov 28, 2012 at 07:16:12AM -0600, Mark Langsdorf wrote: > Standard practice is to have cpufreq_set_target() handle voltage > transitions and leave clk_set_rate() handle the frequency changes. The standard practice is to have cpufreq_set_target() handle both voltage and frequency transition

Re: [PATCH 6/6 v6] cpufreq, highbank: add support for highbank cpufreq

2012-11-28 Thread Mark Langsdorf
On 11/27/2012 08:32 PM, Shawn Guo wrote: > On Tue, Nov 27, 2012 at 02:04:32PM -0600, Mark Langsdorf wrote: >> Highbank processors depend on the external ECME to perform voltage >> management based on a requested frequency. Communication between the >> A9 cores and the ECME happens over the pl320 IP

Re: [PATCH 6/6 v6] cpufreq, highbank: add support for highbank cpufreq

2012-11-27 Thread Shawn Guo
On Tue, Nov 27, 2012 at 02:04:32PM -0600, Mark Langsdorf wrote: > Highbank processors depend on the external ECME to perform voltage > management based on a requested frequency. Communication between the > A9 cores and the ECME happens over the pl320 IPC channel. ... > +static int hb_voltage_chan

[PATCH 6/6 v6] cpufreq, highbank: add support for highbank cpufreq

2012-11-27 Thread Mark Langsdorf
Highbank processors depend on the external ECME to perform voltage management based on a requested frequency. Communication between the A9 cores and the ECME happens over the pl320 IPC channel. Signed-off-by: Mark Langsdorf Cc: devicetree-disc...@lists.ozlabs.org --- Changes from v5 Chang