[PATCH 6/7] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

2016-12-14 Thread Jens Axboe
Signed-off-by: Jens Axboe --- block/Kconfig.iosched | 6 + block/Makefile| 1 + block/mq-deadline.c | 638 ++ 3 files changed, 645 insertions(+) create mode 100644 block/mq-deadline.c diff --git a/block/Kconfig.iosched b/block/Kconfi

Re: [PATCH 6/7] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

2016-12-14 Thread Jens Axboe
On 12/14/2016 01:09 AM, Bart Van Assche wrote: > On 12/08/2016 09:13 PM, Jens Axboe wrote: >> +static inline bool dd_rq_is_shadow(struct request *rq) >> +{ >> +return rq->rq_flags & RQF_ALLOCED; >> +} > > Hello Jens, > > Something minor: because req_flags_t has been defined using __bitwise >

Re: [PATCH 6/7] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

2016-12-14 Thread Bart Van Assche
On 12/08/2016 09:13 PM, Jens Axboe wrote: > +static inline bool dd_rq_is_shadow(struct request *rq) > +{ > + return rq->rq_flags & RQF_ALLOCED; > +} Hello Jens, Something minor: because req_flags_t has been defined using __bitwise (typedef __u32 __bitwise req_flags_t) sparse complains for the

Re: [PATCH 6/7] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

2016-12-13 Thread Jens Axboe
On 12/13/2016 04:04 AM, Bart Van Assche wrote: > On 12/08/2016 09:13 PM, Jens Axboe wrote: >> +static int dd_init_queue(struct request_queue *q, struct elevator_type *e) >> +{ >> +struct deadline_data *dd; >> +struct elevator_queue *eq; >> + >> +eq = elevator_alloc(q, e); >> +if (!e

Re: [PATCH 6/7] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

2016-12-13 Thread Bart Van Assche
On 12/08/2016 09:13 PM, Jens Axboe wrote: +static int dd_init_queue(struct request_queue *q, struct elevator_type *e) +{ + struct deadline_data *dd; + struct elevator_queue *eq; + + eq = elevator_alloc(q, e); + if (!eq) + return -ENOMEM; + + dd = kzallo

[PATCH 6/7] mq-deadline: add blk-mq adaptation of the deadline IO scheduler

2016-12-08 Thread Jens Axboe
Signed-off-by: Jens Axboe --- block/Kconfig.iosched | 6 + block/Makefile| 1 + block/mq-deadline.c | 647 ++ 3 files changed, 654 insertions(+) create mode 100644 block/mq-deadline.c diff --git a/block/Kconfig.iosched b/block/Kconfi