Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic

2015-10-01 Thread Johan Hovold
On Thu, Oct 01, 2015 at 08:17:00AM +0100, Lee Jones wrote: > On Wed, 30 Sep 2015, Johan Hovold wrote: > > > On Tue, Sep 29, 2015 at 01:26:08PM +0200, Javier Martinez Canillas wrote: > > > The invoked functions already return zero on success or a negative > > > errno code so there is no need to ope

Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic

2015-10-01 Thread Lee Jones
On Tue, 29 Sep 2015, Javier Martinez Canillas wrote: > The invoked functions already return zero on success or a negative > errno code so there is no need to open code the logic in the caller. > > Signed-off-by: Javier Martinez Canillas > > --- > > drivers/mfd/lm3533-core.c | 12 ++--

Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic

2015-10-01 Thread Lee Jones
On Wed, 30 Sep 2015, Johan Hovold wrote: > On Tue, Sep 29, 2015 at 01:26:08PM +0200, Javier Martinez Canillas wrote: > > The invoked functions already return zero on success or a negative > > errno code so there is no need to open code the logic in the caller. > > > > Signed-off-by: Javier Martin

Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic

2015-09-30 Thread Johan Hovold
On Wed, Sep 30, 2015 at 11:41:26PM +0200, Javier Martinez Canillas wrote: > On 09/30/2015 11:04 PM, Johan Hovold wrote: > > On Tue, Sep 29, 2015 at 01:26:08PM +0200, Javier Martinez Canillas wrote: > >> diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c > >> index 643f3750e830..193

Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic

2015-09-30 Thread Javier Martinez Canillas
Hello Johan, On 09/30/2015 11:04 PM, Johan Hovold wrote: > On Tue, Sep 29, 2015 at 01:26:08PM +0200, Javier Martinez Canillas wrote: >> The invoked functions already return zero on success or a negative >> errno code so there is no need to open code the logic in the caller. >> >> Signed-off-by: Ja

Re: [PATCH 8/8] mfd: lm3533: Simplify function return logic

2015-09-30 Thread Johan Hovold
On Tue, Sep 29, 2015 at 01:26:08PM +0200, Javier Martinez Canillas wrote: > The invoked functions already return zero on success or a negative > errno code so there is no need to open code the logic in the caller. > > Signed-off-by: Javier Martinez Canillas I do not consider this an improvement

[PATCH 8/8] mfd: lm3533: Simplify function return logic

2015-09-29 Thread Javier Martinez Canillas
The invoked functions already return zero on success or a negative errno code so there is no need to open code the logic in the caller. Signed-off-by: Javier Martinez Canillas --- drivers/mfd/lm3533-core.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/driver