Re: [PATCH AUTOSEL 4.18 043/131] ASoC: soc-pcm: Use delay set in component pointer function

2018-09-07 Thread Mark Brown
On Fri, Sep 07, 2018 at 12:46:21PM +0530, Agrawal, Akshu wrote: > But more likely I think the delay was just getting left out and there > wouldn't have been a compensation in userspace. Yes, I don't think most users are going to notice this either way - the overwhelming majority of them won't hav

Re: [PATCH AUTOSEL 4.18 043/131] ASoC: soc-pcm: Use delay set in component pointer function

2018-09-07 Thread Mark Brown
On Fri, Sep 07, 2018 at 12:23:14AM +, Sasha Levin wrote: > On Mon, Sep 03, 2018 at 12:16:26PM +0100, Mark Brown wrote: > >I'm worried that if anyone notices this at all they will have already > >compensated for the delays in userspace and therefore this will cause > >them to see problems as th

Re: [PATCH AUTOSEL 4.18 043/131] ASoC: soc-pcm: Use delay set in component pointer function

2018-09-07 Thread Agrawal, Akshu
On 9/7/2018 5:53 AM, Sasha Levin wrote: > On Mon, Sep 03, 2018 at 12:16:26PM +0100, Mark Brown wrote: >> On Sun, Sep 02, 2018 at 01:03:55PM +, Sasha Levin wrote: >>> From: Akshu Agrawal >>> >>> [ Upstream commit 9fb4c2bf130b922c77c16a8368732699799c40de ] >>> >>> Take into account the base d

Re: [PATCH AUTOSEL 4.18 043/131] ASoC: soc-pcm: Use delay set in component pointer function

2018-09-06 Thread Sasha Levin
On Mon, Sep 03, 2018 at 12:16:26PM +0100, Mark Brown wrote: >On Sun, Sep 02, 2018 at 01:03:55PM +, Sasha Levin wrote: >> From: Akshu Agrawal >> >> [ Upstream commit 9fb4c2bf130b922c77c16a8368732699799c40de ] >> >> Take into account the base delay set in pointer callback. >> >> There are cases

Re: [PATCH AUTOSEL 4.18 043/131] ASoC: soc-pcm: Use delay set in component pointer function

2018-09-03 Thread Mark Brown
On Sun, Sep 02, 2018 at 01:03:55PM +, Sasha Levin wrote: > From: Akshu Agrawal > > [ Upstream commit 9fb4c2bf130b922c77c16a8368732699799c40de ] > > Take into account the base delay set in pointer callback. > > There are cases where a pointer function populates > runtime->delay, such as: > .

[PATCH AUTOSEL 4.18 043/131] ASoC: soc-pcm: Use delay set in component pointer function

2018-09-02 Thread Sasha Levin
From: Akshu Agrawal [ Upstream commit 9fb4c2bf130b922c77c16a8368732699799c40de ] Take into account the base delay set in pointer callback. There are cases where a pointer function populates runtime->delay, such as: ./sound/pci/hda/hda_controller.c ./sound/soc/intel/atom/sst-mfld-platform-pcm.c