Re: [PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes enumeration

2015-04-21 Thread Dave Hansen
On 04/21/2015 02:16 AM, Thomas Gleixner wrote: > On Sat, 18 Apr 2015, Fenghua Yu wrote: >> From: Fenghua Yu >> When enumerating xstate offsets and sizes from cpuid (eax=0x0d, ecx>=2), >> it's possible that state m is not implemented while state n (n>m) >> is implemented. So enumeration shouldn't

RE: [PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes enumeration

2015-04-21 Thread Thomas Gleixner
On Tue, 21 Apr 2015, Yu, Fenghua wrote: > > This is a regular hardware enablement or are you saying that this is > > backport > > material? > > I would like the patch to be backported to distros or stable kernel because > we may really see the issue in near future if it's not backported. Then

RE: [PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes enumeration

2015-04-21 Thread Yu, Fenghua
> From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Tuesday, April 21, 2015 2:17 AM > On Sat, 18 Apr 2015, Fenghua Yu wrote: > > > From: Fenghua Yu > > > > When enumerating xstate offsets and sizes from cpuid (eax=0x0d, > > ecx>=2), it's possible that state m is not implemented while

Re: [PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes enumeration

2015-04-21 Thread Thomas Gleixner
On Sat, 18 Apr 2015, Fenghua Yu wrote: > From: Fenghua Yu > > When enumerating xstate offsets and sizes from cpuid (eax=0x0d, ecx>=2), > it's possible that state m is not implemented while state n (n>m) > is implemented. So enumeration shouldn't stop at state m. > > There is no platform

Re: [PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes enumeration

2015-04-21 Thread Thomas Gleixner
On Sat, 18 Apr 2015, Fenghua Yu wrote: From: Fenghua Yu fenghua...@intel.com When enumerating xstate offsets and sizes from cpuid (eax=0x0d, ecx=2), it's possible that state m is not implemented while state n (nm) is implemented. So enumeration shouldn't stop at state m. There is no

RE: [PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes enumeration

2015-04-21 Thread Yu, Fenghua
From: Thomas Gleixner [mailto:t...@linutronix.de] Sent: Tuesday, April 21, 2015 2:17 AM On Sat, 18 Apr 2015, Fenghua Yu wrote: From: Fenghua Yu fenghua...@intel.com When enumerating xstate offsets and sizes from cpuid (eax=0x0d, ecx=2), it's possible that state m is not implemented

Re: [PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes enumeration

2015-04-21 Thread Dave Hansen
On 04/21/2015 02:16 AM, Thomas Gleixner wrote: On Sat, 18 Apr 2015, Fenghua Yu wrote: From: Fenghua Yu fenghua...@intel.com When enumerating xstate offsets and sizes from cpuid (eax=0x0d, ecx=2), it's possible that state m is not implemented while state n (nm) is implemented. So enumeration

RE: [PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes enumeration

2015-04-21 Thread Thomas Gleixner
On Tue, 21 Apr 2015, Yu, Fenghua wrote: This is a regular hardware enablement or are you saying that this is backport material? I would like the patch to be backported to distros or stable kernel because we may really see the issue in near future if it's not backported. Then you should

[PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes enumeration

2015-04-18 Thread Fenghua Yu
From: Fenghua Yu When enumerating xstate offsets and sizes from cpuid (eax=0x0d, ecx>=2), it's possible that state m is not implemented while state n (n>m) is implemented. So enumeration shouldn't stop at state m. There is no platform configured like above yet. But this could be a problem in

[PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes enumeration

2015-04-18 Thread Fenghua Yu
From: Fenghua Yu fenghua...@intel.com When enumerating xstate offsets and sizes from cpuid (eax=0x0d, ecx=2), it's possible that state m is not implemented while state n (nm) is implemented. So enumeration shouldn't stop at state m. There is no platform configured like above yet. But this could