Re: [PATCH RESEND] PCI/AER: Use a common function to print AER error bits

2018-05-07 Thread Bjorn Helgaas
On Mon, Apr 30, 2018 at 12:41:26PM -0500, Alex G. wrote: > On 04/30/2018 12:15 PM, Bjorn Helgaas wrote: > > On Sat, Apr 28, 2018 at 12:07:48PM -0500, Alex G. wrote: > > (snip) > >> I could update the offending line to say: > >> + info.first_error = PCI_ERR_CAP_FEP(aer->cap_control); > > > > That

Re: [PATCH RESEND] PCI/AER: Use a common function to print AER error bits

2018-04-30 Thread Alex G.
On 04/30/2018 12:15 PM, Bjorn Helgaas wrote: > On Sat, Apr 28, 2018 at 12:07:48PM -0500, Alex G. wrote: (snip) >> I could update the offending line to say: >> + info.first_error = PCI_ERR_CAP_FEP(aer->cap_control); > > That's what I would have expected. So I'd say either do this, or add > a

Re: [PATCH RESEND] PCI/AER: Use a common function to print AER error bits

2018-04-30 Thread Bjorn Helgaas
On Sat, Apr 28, 2018 at 12:07:48PM -0500, Alex G. wrote: > On 04/28/2018 11:46 AM, Alex G. wrote: > > On 04/27/2018 05:43 PM, Bjorn Helgaas wrote: > > > On Tue, Apr 17, 2018 at 12:09:43PM -0500, Alexandru Gagniuc wrote: > (snip) > > > > +    memset(&info, 0, sizeof(info)); > > > > +    info.severit

Re: [PATCH RESEND] PCI/AER: Use a common function to print AER error bits

2018-04-28 Thread Alex G.
On 04/28/2018 11:46 AM, Alex G. wrote: On 04/27/2018 05:43 PM, Bjorn Helgaas wrote: On Tue, Apr 17, 2018 at 12:09:43PM -0500, Alexandru Gagniuc wrote: (snip) +    memset(&info, 0, sizeof(info)); +    info.severity = aer_severity; +    info.status = status; +    info.mask = mask; +    info.firs

Re: [PATCH RESEND] PCI/AER: Use a common function to print AER error bits

2018-04-28 Thread Alex G.
On 04/27/2018 05:43 PM, Bjorn Helgaas wrote: On Tue, Apr 17, 2018 at 12:09:43PM -0500, Alexandru Gagniuc wrote: On errors reported from CPER, cper_print_bits() was used to log the AER bits. This resulted in hard-to-understand messages, without a prefix. Instead use __aer_print_error() for both n

Re: [PATCH RESEND] PCI/AER: Use a common function to print AER error bits

2018-04-27 Thread Bjorn Helgaas
On Tue, Apr 17, 2018 at 12:09:43PM -0500, Alexandru Gagniuc wrote: > On errors reported from CPER, cper_print_bits() was used to log the > AER bits. This resulted in hard-to-understand messages, without a > prefix. Instead use __aer_print_error() for both native AER and CPER > to provide a more con

Re: [PATCH RESEND] PCI/AER: Use a common function to print AER error bits

2018-04-26 Thread Tyler Baicar
On 4/17/2018 1:09 PM, Alexandru Gagniuc wrote: On errors reported from CPER, cper_print_bits() was used to log the AER bits. This resulted in hard-to-understand messages, without a prefix. Instead use __aer_print_error() for both native AER and CPER to provide a more consistent log format. Signe

[PATCH RESEND] PCI/AER: Use a common function to print AER error bits

2018-04-17 Thread Alexandru Gagniuc
On errors reported from CPER, cper_print_bits() was used to log the AER bits. This resulted in hard-to-understand messages, without a prefix. Instead use __aer_print_error() for both native AER and CPER to provide a more consistent log format. Signed-off-by: Alexandru Gagniuc --- drivers/pci/pci