Re: [PATCH RFC] media: i2c: mt9p031: add OF support

Hi Sascha, On Tuesday 30 April 2013 08:16:25 Sascha Hauer wrote: > On Mon, Apr 29, 2013 at 01:30:01PM +0530, Prabhakar Lad wrote: > > From: Lad, Prabhakar > > > > add OF support for the mt9p031 sensor driver. > > > > +static struct mt9p031_platform_data > > + *mt9p031_get_pdata(struct

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

Hi, One more point for your devicetree conversions, On Mon, Apr 29, 2013 at 01:30:01PM +0530, Prabhakar Lad wrote: > From: Lad, Prabhakar > > add OF support for the mt9p031 sensor driver. > > +static struct mt9p031_platform_data > + *mt9p031_get_pdata(struct i2c_client *client) > + > +{ >

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

Hi, One more point for your devicetree conversions, On Mon, Apr 29, 2013 at 01:30:01PM +0530, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com add OF support for the mt9p031 sensor driver. +static struct mt9p031_platform_data + *mt9p031_get_pdata(struct i2c_client

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

Hi Sascha, On Tuesday 30 April 2013 08:16:25 Sascha Hauer wrote: On Mon, Apr 29, 2013 at 01:30:01PM +0530, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com add OF support for the mt9p031 sensor driver. +static struct mt9p031_platform_data +

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

On Monday 29 April 2013 17:18:02 Prabhakar Lad wrote: > On Mon, Apr 29, 2013 at 5:05 PM, Laurent Pinchart wrote: > > Hi Prabhakar, > > > > Thank you for the patch. Please see below for a couple of comments in > > addition to the ones I've just sent (in reply to Sascha's e-mail). > > Yep fixed

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

Hi Laurent, On Mon, Apr 29, 2013 at 5:05 PM, Laurent Pinchart wrote: > Hi Prabhakar, > > Thank you for the patch. Please see below for a couple of comments in addition > to the ones I've just sent (in reply to Sascha's e-mail). > Yep fixed them all. [snip] > >> --- >>

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

Hi Prabhakar, Thank you for the patch. Please see below for a couple of comments in addition to the ones I've just sent (in reply to Sascha's e-mail). On Monday 29 April 2013 13:30:01 Prabhakar Lad wrote: > From: Lad, Prabhakar > > add OF support for the mt9p031 sensor driver. > >

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

Hi Prabhakar, On Monday 29 April 2013 16:41:07 Prabhakar Lad wrote: > On Mon, Apr 29, 2013 at 1:51 PM, Sascha Hauer wrote: > > > >> +Required Properties : > >> +- compatible : value should be either one among the following > >> + (a) "aptina,mt9p031-sensor" for mt9p031 sensor > >> + (b)

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

Hi Sascha, Thanks for the quick review. On Mon, Apr 29, 2013 at 1:51 PM, Sascha Hauer wrote: >> +Required Properties : >> +- compatible : value should be either one among the following >> + (a) "aptina,mt9p031-sensor" for mt9p031 sensor >> + (b) "aptina,mt9p031m-sensor" for mt9p031m

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

On Mon, Apr 29, 2013 at 01:30:01PM +0530, Prabhakar Lad wrote: > From: Lad, Prabhakar > > add OF support for the mt9p031 sensor driver. > > Signed-off-by: Lad, Prabhakar > Cc: Hans Verkuil > Cc: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: Guennadi Liakhovetski > Cc: Sylwester

[PATCH RFC] media: i2c: mt9p031: add OF support

From: Lad, Prabhakar add OF support for the mt9p031 sensor driver. Signed-off-by: Lad, Prabhakar Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Mauro Carvalho Chehab Cc: Guennadi Liakhovetski Cc: Sylwester Nawrocki Cc: Sakari Ailus Cc: Grant Likely Cc: Rob Herring Cc: Rob Landley Cc:

[PATCH RFC] media: i2c: mt9p031: add OF support

From: Lad, Prabhakar prabhakar.cse...@gmail.com add OF support for the mt9p031 sensor driver. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cc: Hans Verkuil hans.verk...@cisco.com Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Mauro Carvalho Chehab mche...@redhat.com Cc:

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

On Mon, Apr 29, 2013 at 01:30:01PM +0530, Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com add OF support for the mt9p031 sensor driver. Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com Cc: Hans Verkuil hans.verk...@cisco.com Cc: Laurent Pinchart

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

Hi Sascha, Thanks for the quick review. On Mon, Apr 29, 2013 at 1:51 PM, Sascha Hauer s.ha...@pengutronix.de wrote: Snip +Required Properties : +- compatible : value should be either one among the following + (a) aptina,mt9p031-sensor for mt9p031 sensor + (b) aptina,mt9p031m-sensor

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

Hi Prabhakar, On Monday 29 April 2013 16:41:07 Prabhakar Lad wrote: On Mon, Apr 29, 2013 at 1:51 PM, Sascha Hauer wrote: Snip +Required Properties : +- compatible : value should be either one among the following + (a) aptina,mt9p031-sensor for mt9p031 sensor + (b)

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

Hi Prabhakar, Thank you for the patch. Please see below for a couple of comments in addition to the ones I've just sent (in reply to Sascha's e-mail). On Monday 29 April 2013 13:30:01 Prabhakar Lad wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com add OF support for the mt9p031 sensor

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

Hi Laurent, On Mon, Apr 29, 2013 at 5:05 PM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Prabhakar, Thank you for the patch. Please see below for a couple of comments in addition to the ones I've just sent (in reply to Sascha's e-mail). Yep fixed them all. [snip] ---

Re: [PATCH RFC] media: i2c: mt9p031: add OF support

On Monday 29 April 2013 17:18:02 Prabhakar Lad wrote: On Mon, Apr 29, 2013 at 5:05 PM, Laurent Pinchart wrote: Hi Prabhakar, Thank you for the patch. Please see below for a couple of comments in addition to the ones I've just sent (in reply to Sascha's e-mail). Yep fixed them all.