Re: [PATCH RFC 04/24] mm: gup: allow VM_FAULT_RETRY for multiple times

2019-01-24 Thread Peter Xu
On Thu, Jan 24, 2019 at 10:34:32AM -0500, Jerome Glisse wrote: > On Thu, Jan 24, 2019 at 03:05:03PM +0800, Peter Xu wrote: > > On Mon, Jan 21, 2019 at 11:24:55AM -0500, Jerome Glisse wrote: > > > On Mon, Jan 21, 2019 at 03:57:02PM +0800, Peter Xu wrote: > > > > This is the gup counterpart of the ch

Re: [PATCH RFC 04/24] mm: gup: allow VM_FAULT_RETRY for multiple times

2019-01-24 Thread Jerome Glisse
On Thu, Jan 24, 2019 at 03:05:03PM +0800, Peter Xu wrote: > On Mon, Jan 21, 2019 at 11:24:55AM -0500, Jerome Glisse wrote: > > On Mon, Jan 21, 2019 at 03:57:02PM +0800, Peter Xu wrote: > > > This is the gup counterpart of the change that allows the VM_FAULT_RETRY > > > to happen for more than once.

Re: [PATCH RFC 04/24] mm: gup: allow VM_FAULT_RETRY for multiple times

2019-01-23 Thread Peter Xu
On Mon, Jan 21, 2019 at 11:24:55AM -0500, Jerome Glisse wrote: > On Mon, Jan 21, 2019 at 03:57:02PM +0800, Peter Xu wrote: > > This is the gup counterpart of the change that allows the VM_FAULT_RETRY > > to happen for more than once. > > > > Signed-off-by: Peter Xu > > So it would be nice to add

Re: [PATCH RFC 04/24] mm: gup: allow VM_FAULT_RETRY for multiple times

2019-01-21 Thread Jerome Glisse
On Mon, Jan 21, 2019 at 03:57:02PM +0800, Peter Xu wrote: > This is the gup counterpart of the change that allows the VM_FAULT_RETRY > to happen for more than once. > > Signed-off-by: Peter Xu So it would be nice to add a comment in the code and in the commit message about possible fault starvat

[PATCH RFC 04/24] mm: gup: allow VM_FAULT_RETRY for multiple times

2019-01-20 Thread Peter Xu
This is the gup counterpart of the change that allows the VM_FAULT_RETRY to happen for more than once. Signed-off-by: Peter Xu --- mm/gup.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 7b1f452cc2ef..22f1d419a849 100644 --- a/mm/