Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-27 Thread Uwe Kleine-König
Hello Martin, On Mon, Jul 27, 2020 at 09:58:01AM +0200, Martin Botka wrote: > > I hit "reply-to-all" and the mail only was sent to you because you wrote > > to only me. > > Yes my reply was only to you. But your original message was sent only to me > too. > So when i clicked reply to all it was

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-27 Thread Martin Botka
Hello, > I hit "reply-to-all" and the mail only was sent to you because you wrote > to only me. Yes my reply was only to you. But your original message was sent only to me too. So when i clicked reply to all it was only you as you sent it only to me. > Also threading is somehow strange because

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-27 Thread Uwe Kleine-König
Hello Martin, On Mon, Jul 27, 2020 at 09:29:19AM +0200, Martin Botka wrote: > On Sat, Jul 25, 2020 at 09:12:23PM +0200, Martin Botka wrote: > >> > Note there is already a series that changes these values to u64. See > >> > a9d887dc1c60ed67f2271d66560cdcf864c4a578 in linux-next. > >> > >> Amazing.

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-27 Thread Martin Botka
> Could you please send the messages also to everyone else ? Next time of course.

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-27 Thread Martin Botka
Hello Uwe, On Sat, Jul 25, 2020 at 09:12:23PM +0200, Martin Botka wrote: >> > Note there is already a series that changes these values to u64. See >> > a9d887dc1c60ed67f2271d66560cdcf864c4a578 in linux-next. >> >> Amazing. But isn't there the same issue with it as this one where this >> would

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-26 Thread Martin Botka
> And all divisions go mad on 32-bit CPU, right? > Please, if you thought about it carefully, update a commit message to > clarify that. Hello, This patch will be dropped in V2 since another series already made these u64. See a9d887dc1c60ed67f2271d66560cdcf864c4a578 in linux-next. I have not

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-26 Thread Andy Shevchenko
On Sat, Jul 25, 2020 at 12:40 AM Martin Botka wrote: > > From: Fenglin Wu > > Currently, PWM core driver provides interfaces for configuring PWM > period and duty length in nanoseconds with an integer data type, so > the max period can be only set to ~2.147 seconds. Add interfaces which > can

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-25 Thread Martin Botka
> +#include > - gain_q23 = (gain_q23 * dmic->boost_gain) / 100; > + gain_q23 = div_u64(gain_q23 * dmic->boost_gain, 100); Ok so using a macro. Thank you.

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-25 Thread Pavel Machek
Hi! > As can be seen this divides llu by llu in few warnings and error. > At the time of sending i didn't realize it but this fails on 32 bit > architectures. > > So i would like to ask how would you like this fixed ? > Using macro or some other way ? +#include - gain_q23 =

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-25 Thread Martin Botka
Hello, As can be seen this divides llu by llu in few warnings and error. At the time of sending i didn't realize it but this fails on 32 bit architectures. So i would like to ask how would you like this fixed ? Using macro or some other way ? Thank you. Best regards, Martin

[PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-24 Thread Martin Botka
From: Fenglin Wu Currently, PWM core driver provides interfaces for configuring PWM period and duty length in nanoseconds with an integer data type, so the max period can be only set to ~2.147 seconds. Add interfaces which can set PWM period and duty with u64 data type to remove this limitation.