Re: [PATCH V1 1/3] ARM: clk-imx6sl: refine clock tree for SSI

2014-09-15 Thread Fabio Estevam
On Mon, Sep 15, 2014 at 11:48 AM, Shawn Guo wrote: > Shengjiu, > > Your analysis is right. I hope the following change will get the shared > gate clock code eventually does the right thing. > > Shawn > > diff --git a/arch/arm/mach-imx/clk-gate2.c b/arch/arm/mach-imx/clk-gate2.c > index 84acdfd1d

Re: [PATCH V1 1/3] ARM: clk-imx6sl: refine clock tree for SSI

2014-09-15 Thread Shawn Guo
On Mon, Sep 15, 2014 at 07:58:56PM +0800, Shengjiu Wang wrote: > I add IMX6QDL_CLK_SSIx in this patch, which use share count with > IMX6QDL_CLK_SSIx_IPG. The SSI driver sound/soc/fsl/fsl_ssi.c will enable > IMX6QDL_CLK_SSIx_IPG clock in probe, but don't disable it. In the end of > kernel > boot u

Re: [PATCH V1 1/3] ARM: clk-imx6sl: refine clock tree for SSI

2014-09-15 Thread Shengjiu Wang
Hi fabio, shawn. On Fri, Sep 12, 2014 at 01:43:39PM -0300, Fabio Estevam wrote: > On Fri, Sep 12, 2014 at 1:35 PM, Fabio Estevam wrote: > > On Tue, Sep 9, 2014 at 6:13 AM, Shengjiu Wang > > wrote: > >> Each SSI has "ssi", "ssi_ipg" clocks, and they share same gate bits. > >> > >> Signed-off-by:

Re: [PATCH V1 1/3] ARM: clk-imx6sl: refine clock tree for SSI

2014-09-12 Thread Fabio Estevam
On Fri, Sep 12, 2014 at 1:35 PM, Fabio Estevam wrote: > On Tue, Sep 9, 2014 at 6:13 AM, Shengjiu Wang > wrote: >> Each SSI has "ssi", "ssi_ipg" clocks, and they share same gate bits. >> >> Signed-off-by: Shengjiu Wang > > This patch breaks audio playback on imx6q-sabresd: > > root@freescale /$ a

Re: [PATCH V1 1/3] ARM: clk-imx6sl: refine clock tree for SSI

2014-09-12 Thread Fabio Estevam
On Tue, Sep 9, 2014 at 6:13 AM, Shengjiu Wang wrote: > Each SSI has "ssi", "ssi_ipg" clocks, and they share same gate bits. > > Signed-off-by: Shengjiu Wang This patch breaks audio playback on imx6q-sabresd: root@freescale /$ aplay /home/clarinet.wav Playing WAVE '/home/clarinet.wav' : Signed 1

[PATCH V1 1/3] ARM: clk-imx6sl: refine clock tree for SSI

2014-09-09 Thread Shengjiu Wang
Each SSI has "ssi", "ssi_ipg" clocks, and they share same gate bits. Signed-off-by: Shengjiu Wang --- arch/arm/mach-imx/clk-imx6sl.c | 13 ++--- include/dt-bindings/clock/imx6sl-clock.h |5 - 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/arch/arm/mac