RE: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-15 Thread Moore, Robert
thew Garrett > Cc: Rafael J. Wysocki; Dmitry Torokhov; l...@kernel.org; linux- > a...@vger.kernel.org; linux-kernel@vger.kernel.org; f...@adinet.com.uy; > l...@dorileo.org; Zheng, Lv; Moore, Robert > Subject: Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS > > O

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-15 Thread Lan Tianyu
On 01/15/2014 10:47 PM, Matthew Garrett wrote: On Wed, Jan 15, 2014 at 10:42:31PM +0800, Lan Tianyu wrote: diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index fbf1ace..e98fa83 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -770,7 +770,7 @@ static int

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-15 Thread Matthew Garrett
On Wed, Jan 15, 2014 at 10:42:31PM +0800, Lan Tianyu wrote: > diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c > index fbf1ace..e98fa83 100644 > --- a/drivers/acpi/battery.c > +++ b/drivers/acpi/battery.c > @@ -770,7 +770,7 @@ static int acpi_battery_add(struct acpi_device *device) >

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-15 Thread Lan Tianyu
On 01/15/2014 06:17 AM, Rafael J. Wysocki wrote: On Tuesday, January 14, 2014 09:24:06 PM Matthew Garrett wrote: On Tue, Jan 14, 2014 at 10:37:02PM +0100, Rafael J. Wysocki wrote: On Tuesday, January 14, 2014 04:06:01 PM Matthew Garrett wrote: On Mon, Jan 06, 2014 at 11:25:53PM +0100, Rafael

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-15 Thread Lan Tianyu
On 01/15/2014 06:17 AM, Rafael J. Wysocki wrote: On Tuesday, January 14, 2014 09:24:06 PM Matthew Garrett wrote: On Tue, Jan 14, 2014 at 10:37:02PM +0100, Rafael J. Wysocki wrote: On Tuesday, January 14, 2014 04:06:01 PM Matthew Garrett wrote: On Mon, Jan 06, 2014 at 11:25:53PM +0100, Rafael

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-15 Thread Matthew Garrett
On Wed, Jan 15, 2014 at 10:42:31PM +0800, Lan Tianyu wrote: diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index fbf1ace..e98fa83 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -770,7 +770,7 @@ static int acpi_battery_add(struct acpi_device *device)

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-15 Thread Lan Tianyu
On 01/15/2014 10:47 PM, Matthew Garrett wrote: On Wed, Jan 15, 2014 at 10:42:31PM +0800, Lan Tianyu wrote: diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c index fbf1ace..e98fa83 100644 --- a/drivers/acpi/battery.c +++ b/drivers/acpi/battery.c @@ -770,7 +770,7 @@ static int

RE: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-15 Thread Moore, Robert
: Rafael J. Wysocki; Dmitry Torokhov; l...@kernel.org; linux- a...@vger.kernel.org; linux-kernel@vger.kernel.org; f...@adinet.com.uy; l...@dorileo.org; Zheng, Lv; Moore, Robert Subject: Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS On 01/15/2014 10:47 PM, Matthew Garrett wrote

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-14 Thread Robert Hancock
On 01/14/2014 03:37 PM, Rafael J. Wysocki wrote: On Tuesday, January 14, 2014 04:06:01 PM Matthew Garrett wrote: On Mon, Jan 06, 2014 at 11:25:53PM +0100, Rafael J. Wysocki wrote: Queued up as a fix for 3.13 (I fixed up the indentation). Ah, sorry, I missed this chunk of the thread. If the

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-14 Thread Rafael J. Wysocki
On Tuesday, January 14, 2014 09:24:06 PM Matthew Garrett wrote: > On Tue, Jan 14, 2014 at 10:37:02PM +0100, Rafael J. Wysocki wrote: > > On Tuesday, January 14, 2014 04:06:01 PM Matthew Garrett wrote: > > > On Mon, Jan 06, 2014 at 11:25:53PM +0100, Rafael J. Wysocki wrote: > > > > > > > Queued up

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-14 Thread Matthew Garrett
On Tue, Jan 14, 2014 at 10:37:02PM +0100, Rafael J. Wysocki wrote: > On Tuesday, January 14, 2014 04:06:01 PM Matthew Garrett wrote: > > On Mon, Jan 06, 2014 at 11:25:53PM +0100, Rafael J. Wysocki wrote: > > > > > Queued up as a fix for 3.13 (I fixed up the indentation). > > > > Ah, sorry, I

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-14 Thread Rafael J. Wysocki
On Tuesday, January 14, 2014 04:06:01 PM Matthew Garrett wrote: > On Mon, Jan 06, 2014 at 11:25:53PM +0100, Rafael J. Wysocki wrote: > > > Queued up as a fix for 3.13 (I fixed up the indentation). > > Ah, sorry, I missed this chunk of the thread. If the system provides > valid _BIF data then we

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-14 Thread Matthew Garrett
On Mon, Jan 06, 2014 at 11:25:53PM +0100, Rafael J. Wysocki wrote: > Queued up as a fix for 3.13 (I fixed up the indentation). Ah, sorry, I missed this chunk of the thread. If the system provides valid _BIF data then we should possibly just fall back to that rather than adding another quirk

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-14 Thread Matthew Garrett
On Mon, Jan 06, 2014 at 11:25:53PM +0100, Rafael J. Wysocki wrote: Queued up as a fix for 3.13 (I fixed up the indentation). Ah, sorry, I missed this chunk of the thread. If the system provides valid _BIF data then we should possibly just fall back to that rather than adding another quirk

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-14 Thread Rafael J. Wysocki
On Tuesday, January 14, 2014 04:06:01 PM Matthew Garrett wrote: On Mon, Jan 06, 2014 at 11:25:53PM +0100, Rafael J. Wysocki wrote: Queued up as a fix for 3.13 (I fixed up the indentation). Ah, sorry, I missed this chunk of the thread. If the system provides valid _BIF data then we should

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-14 Thread Matthew Garrett
On Tue, Jan 14, 2014 at 10:37:02PM +0100, Rafael J. Wysocki wrote: On Tuesday, January 14, 2014 04:06:01 PM Matthew Garrett wrote: On Mon, Jan 06, 2014 at 11:25:53PM +0100, Rafael J. Wysocki wrote: Queued up as a fix for 3.13 (I fixed up the indentation). Ah, sorry, I missed this

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-14 Thread Rafael J. Wysocki
On Tuesday, January 14, 2014 09:24:06 PM Matthew Garrett wrote: On Tue, Jan 14, 2014 at 10:37:02PM +0100, Rafael J. Wysocki wrote: On Tuesday, January 14, 2014 04:06:01 PM Matthew Garrett wrote: On Mon, Jan 06, 2014 at 11:25:53PM +0100, Rafael J. Wysocki wrote: Queued up as a fix for

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-14 Thread Robert Hancock
On 01/14/2014 03:37 PM, Rafael J. Wysocki wrote: On Tuesday, January 14, 2014 04:06:01 PM Matthew Garrett wrote: On Mon, Jan 06, 2014 at 11:25:53PM +0100, Rafael J. Wysocki wrote: Queued up as a fix for 3.13 (I fixed up the indentation). Ah, sorry, I missed this chunk of the thread. If the

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-06 Thread Rafael J. Wysocki
On Monday, January 06, 2014 09:59:12 AM Dmitry Torokhov wrote: > Hi Lan, > > On Mon, Jan 06, 2014 at 10:50:37PM +0800, Lan Tianyu wrote: > > The aml method _BIX of NEC LZ750/LS returns a broken package which > > skip the first member "Revision" according ACPI 5.0 spec Table 10-234. > > > > This

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-06 Thread Dmitry Torokhov
Hi Lan, On Mon, Jan 06, 2014 at 10:50:37PM +0800, Lan Tianyu wrote: > The aml method _BIX of NEC LZ750/LS returns a broken package which > skip the first member "Revision" according ACPI 5.0 spec Table 10-234. > > This patch is to add a quirk for this machine to skip member "Revision" > during

[PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-06 Thread Lan Tianyu
The aml method _BIX of NEC LZ750/LS returns a broken package which skip the first member "Revision" according ACPI 5.0 spec Table 10-234. This patch is to add a quirk for this machine to skip member "Revision" during parsing _BIX returned package. Reported-and-tested-by: Francisco Castro

[PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-06 Thread Lan Tianyu
The aml method _BIX of NEC LZ750/LS returns a broken package which skip the first member Revision according ACPI 5.0 spec Table 10-234. This patch is to add a quirk for this machine to skip member Revision during parsing _BIX returned package. Reported-and-tested-by: Francisco Castro

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-06 Thread Dmitry Torokhov
Hi Lan, On Mon, Jan 06, 2014 at 10:50:37PM +0800, Lan Tianyu wrote: The aml method _BIX of NEC LZ750/LS returns a broken package which skip the first member Revision according ACPI 5.0 spec Table 10-234. This patch is to add a quirk for this machine to skip member Revision during parsing

Re: [PATCH V2] ACPI/Battery: Add a _BIX quirk for NEC LZ750/LS

2014-01-06 Thread Rafael J. Wysocki
On Monday, January 06, 2014 09:59:12 AM Dmitry Torokhov wrote: Hi Lan, On Mon, Jan 06, 2014 at 10:50:37PM +0800, Lan Tianyu wrote: The aml method _BIX of NEC LZ750/LS returns a broken package which skip the first member Revision according ACPI 5.0 spec Table 10-234. This patch is to