Re: [PATCH V2] mm, page_alloc: fix core hung in free_pcppages_bulk()

2020-08-13 Thread Michal Hocko
On Thu 13-08-20 22:57:32, Charan Teja Kalla wrote: > Thanks Michal. > > On 8/13/2020 10:00 PM, Michal Hocko wrote: > > On Thu 13-08-20 21:51:29, Charan Teja Kalla wrote: > >> Thanks Michal for comments. > >> > >> On 8/13/2020 5:11 PM, Michal Hocko wrote: > >>> On Tue 11-08-20 18:28:23, Charan Teja

Re: [PATCH V2] mm, page_alloc: fix core hung in free_pcppages_bulk()

2020-08-13 Thread Charan Teja Kalla
Thanks Michal. On 8/13/2020 10:00 PM, Michal Hocko wrote: > On Thu 13-08-20 21:51:29, Charan Teja Kalla wrote: >> Thanks Michal for comments. >> >> On 8/13/2020 5:11 PM, Michal Hocko wrote: >>> On Tue 11-08-20 18:28:23, Charan Teja Reddy wrote: >>> [...] diff --git a/mm/page_alloc.c b/mm/page

Re: [PATCH V2] mm, page_alloc: fix core hung in free_pcppages_bulk()

2020-08-13 Thread Michal Hocko
On Thu 13-08-20 21:51:29, Charan Teja Kalla wrote: > Thanks Michal for comments. > > On 8/13/2020 5:11 PM, Michal Hocko wrote: > > On Tue 11-08-20 18:28:23, Charan Teja Reddy wrote: > > [...] > >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c > >> index e4896e6..839039f 100644 > >> --- a/mm/page_

Re: [PATCH V2] mm, page_alloc: fix core hung in free_pcppages_bulk()

2020-08-13 Thread Charan Teja Kalla
Thanks Michal for comments. On 8/13/2020 5:11 PM, Michal Hocko wrote: > On Tue 11-08-20 18:28:23, Charan Teja Reddy wrote: > [...] >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >> index e4896e6..839039f 100644 >> --- a/mm/page_alloc.c >> +++ b/mm/page_alloc.c >> @@ -1304,6 +1304,11 @@ static v

Re: [PATCH V2] mm, page_alloc: fix core hung in free_pcppages_bulk()

2020-08-13 Thread Michal Hocko
On Tue 11-08-20 18:28:23, Charan Teja Reddy wrote: [...] > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index e4896e6..839039f 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -1304,6 +1304,11 @@ static void free_pcppages_bulk(struct zone *zone, int > count, > struct page *pag

Re: [PATCH V2] mm, page_alloc: fix core hung in free_pcppages_bulk()

2020-08-13 Thread David Hildenbrand
On 12.08.20 12:11, Charan Teja Kalla wrote: > > > On 8/12/2020 3:30 PM, David Hildenbrand wrote: >> On 12.08.20 11:46, Charan Teja Kalla wrote: >>> >>> Thanks David for the inputs. >>> >>> On 8/12/2020 2:35 AM, David Hildenbrand wrote: On 11.08.20 14:58, Charan Teja Reddy wrote: > The fo

Re: [PATCH V2] mm, page_alloc: fix core hung in free_pcppages_bulk()

2020-08-12 Thread David Rientjes
On Wed, 12 Aug 2020, Charan Teja Kalla wrote: > >> Signed-off-by: Charan Teja Reddy > >> --- > >> > >> v1: https://patchwork.kernel.org/patch/11707637/ > >> > >> mm/page_alloc.c | 5 + > >> 1 file changed, 5 insertions(+) > >> > >> diff --git a/mm/page_alloc.c b/mm/page_alloc.c > >> index e4

Re: [PATCH V2] mm, page_alloc: fix core hung in free_pcppages_bulk()

2020-08-12 Thread Charan Teja Kalla
On 8/12/2020 3:30 PM, David Hildenbrand wrote: > On 12.08.20 11:46, Charan Teja Kalla wrote: >> >> Thanks David for the inputs. >> >> On 8/12/2020 2:35 AM, David Hildenbrand wrote: >>> On 11.08.20 14:58, Charan Teja Reddy wrote: The following race is observed with the repeated online, offli

Re: [PATCH V2] mm, page_alloc: fix core hung in free_pcppages_bulk()

2020-08-12 Thread David Hildenbrand
On 12.08.20 11:46, Charan Teja Kalla wrote: > > Thanks David for the inputs. > > On 8/12/2020 2:35 AM, David Hildenbrand wrote: >> On 11.08.20 14:58, Charan Teja Reddy wrote: >>> The following race is observed with the repeated online, offline and a >>> delay between two successive online of memo

Re: [PATCH V2] mm, page_alloc: fix core hung in free_pcppages_bulk()

2020-08-12 Thread Charan Teja Kalla
Thanks David for the inputs. On 8/12/2020 2:35 AM, David Hildenbrand wrote: > On 11.08.20 14:58, Charan Teja Reddy wrote: >> The following race is observed with the repeated online, offline and a >> delay between two successive online of memory blocks of movable zone. >> >> P1

Re: [PATCH V2] mm, page_alloc: fix core hung in free_pcppages_bulk()

2020-08-11 Thread David Hildenbrand
On 11.08.20 14:58, Charan Teja Reddy wrote: > The following race is observed with the repeated online, offline and a > delay between two successive online of memory blocks of movable zone. > > P1P2 > > Online the first memory block in > the movable zone

[PATCH V2] mm, page_alloc: fix core hung in free_pcppages_bulk()

2020-08-11 Thread Charan Teja Reddy
The following race is observed with the repeated online, offline and a delay between two successive online of memory blocks of movable zone. P1 P2 Online the first memory block in the movable zone. The pcp struct values are initialized to default value