Re: [PATCH V2] w1: ds2408: add magic sequence to disable P0 test mode

2013-05-10 Thread Evgeniy Polyakov
On Thu, May 09, 2013 at 03:33:23PM -0400, Jean-François Dagenais (jeff.dagen...@gmail.com) wrote: > To be honest, I didn't really thought about it that much, I just copy pasted > that from Evgeniy Polyakov's hunk at drivers/w1/w1_io.c, function > w1_reset_select_slave(struct w1_slave *sl) exept

Re: [PATCH V2] w1: ds2408: add magic sequence to disable P0 test mode

2013-05-10 Thread Evgeniy Polyakov
On Thu, May 09, 2013 at 03:33:23PM -0400, Jean-François Dagenais (jeff.dagen...@gmail.com) wrote: To be honest, I didn't really thought about it that much, I just copy pasted that from Evgeniy Polyakov's hunk at drivers/w1/w1_io.c, function w1_reset_select_slave(struct w1_slave *sl) exept I

Re: [PATCH V2] w1: ds2408: add magic sequence to disable P0 test mode

2013-05-09 Thread Jean-François Dagenais
On 2013-05-09, at 2:03 PM, Andrew Morton wrote: [...] >> +static int w1_f29_disable_test_mode(struct w1_slave *sl) >> +{ >> +int res; >> +u8 magic[10] = {0x96, }; >> +u64 rn = le64_to_cpu(*((u64*)>reg_num)); >> +memcpy([1], , 8); >> +magic[9] = 0x3C; > > (please put a blank

Re: [PATCH V2] w1: ds2408: add magic sequence to disable P0 test mode

2013-05-09 Thread Andrew Morton
On Tue, 7 May 2013 10:00:48 -0400 Jean-Francois Dagenais wrote: > V2: use the new bus_mutex > > extract from http://datasheets.maximintegrated.com/en/ds/DS2408.pdf: > > Power-up timing > The DS2408 is sensitive to the power-on slew rate and can inadvertently > power up with a test mode

Re: [PATCH V2] w1: ds2408: add magic sequence to disable P0 test mode

2013-05-09 Thread Andrew Morton
On Tue, 7 May 2013 10:00:48 -0400 Jean-Francois Dagenais jeff.dagen...@gmail.com wrote: V2: use the new bus_mutex extract from http://datasheets.maximintegrated.com/en/ds/DS2408.pdf: Power-up timing The DS2408 is sensitive to the power-on slew rate and can inadvertently power up with a

Re: [PATCH V2] w1: ds2408: add magic sequence to disable P0 test mode

2013-05-09 Thread Jean-François Dagenais
On 2013-05-09, at 2:03 PM, Andrew Morton wrote: [...] +static int w1_f29_disable_test_mode(struct w1_slave *sl) +{ +int res; +u8 magic[10] = {0x96, }; +u64 rn = le64_to_cpu(*((u64*)sl-reg_num)); +memcpy(magic[1], rn, 8); +magic[9] = 0x3C; (please put a blank line

[PATCH V2] w1: ds2408: add magic sequence to disable P0 test mode

2013-05-07 Thread Jean-Francois Dagenais
V2: use the new bus_mutex extract from http://datasheets.maximintegrated.com/en/ds/DS2408.pdf: Power-up timing The DS2408 is sensitive to the power-on slew rate and can inadvertently power up with a test mode feature enabled. When this occurs, the P0 port does not respond to the Channel Access

[PATCH V2] w1: ds2408: add magic sequence to disable P0 test mode

2013-05-07 Thread Jean-Francois Dagenais
V2: use the new bus_mutex extract from http://datasheets.maximintegrated.com/en/ds/DS2408.pdf: Power-up timing The DS2408 is sensitive to the power-on slew rate and can inadvertently power up with a test mode feature enabled. When this occurs, the P0 port does not respond to the Channel Access