RE: [PATCH V2 1/2] soc: imx: Add SCU SoC info driver support

2019-05-15 Thread Anson Huang
ux-arm- > ker...@lists.infradead.org; linux-kernel@vger.kernel.org; dl-linux-imx > ; Aisheng Dong > Subject: Re: [PATCH V2 1/2] soc: imx: Add SCU SoC info driver support > > On 15.05.2019 11:32, Anson Huang wrote: > > Add i.MX SCU SoC info driver to support i.MX8QXP SoC, introduce

RE: [PATCH V2 1/2] soc: imx: Add SCU SoC info driver support

2019-05-15 Thread Anson Huang
onix.de; Abel Vesa ; r...@kernel.org; > linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; dl-linux- > imx > Subject: Re: [PATCH V2 1/2] soc: imx: Add SCU SoC info driver support > > Hi Anson, > > Since you are going to send a new version for this plea

Re: [PATCH V2 1/2] soc: imx: Add SCU SoC info driver support

2019-05-15 Thread Daniel Baluta
Hi Anson, Since you are going to send a new version for this please consider my comment inline. > +static u32 imx8qxp_soc_revision(void) > +{ > + struct imx_sc_msg_misc_get_soc_id msg; > + struct imx_sc_rpc_msg *hdr = > + u32 rev = 0; No need to initialize this here. > +

Re: [PATCH V2 1/2] soc: imx: Add SCU SoC info driver support

2019-05-15 Thread Leonard Crestez
On 15.05.2019 11:32, Anson Huang wrote: > Add i.MX SCU SoC info driver to support i.MX8QXP SoC, introduce > driver dependency into Kconfig as CONFIG_IMX_SCU must be > selected to support i.MX SCU SoC driver, also need to use > platform driver model to make sure IMX_SCU driver is probed > before

[PATCH V2 1/2] soc: imx: Add SCU SoC info driver support

2019-05-15 Thread Anson Huang
Add i.MX SCU SoC info driver to support i.MX8QXP SoC, introduce driver dependency into Kconfig as CONFIG_IMX_SCU must be selected to support i.MX SCU SoC driver, also need to use platform driver model to make sure IMX_SCU driver is probed before i.MX SCU SoC driver. With this patch, SoC info can