Re: [PATCH V2 linux-next] cpufreq: pxa: replace typedef pxa_freqs_t by structure

2015-04-30 Thread Rafael J. Wysocki
On Thursday, April 30, 2015 08:28:56 PM Fabian Frederick wrote: > > > On 30 April 2015 at 06:46 Joe Perches wrote: > > > > > > On Wed, 2015-04-29 at 21:32 +0200, Fabian Frederick wrote: > > > typedef is not really useful here. Replace it by structure > > > to improve readability.typedef should

Re: [PATCH V2 linux-next] cpufreq: pxa: replace typedef pxa_freqs_t by structure

2015-04-30 Thread Fabian Frederick
> On 30 April 2015 at 06:46 Joe Perches wrote: > > > On Wed, 2015-04-29 at 21:32 +0200, Fabian Frederick wrote: > > typedef is not really useful here. Replace it by structure > > to improve readability.typedef should only be used in some cases. > > (See Documentation/CodingStyle Chapter 5 for

Re: [PATCH V2 linux-next] cpufreq: pxa: replace typedef pxa_freqs_t by structure

2015-04-30 Thread Fabian Frederick
On 30 April 2015 at 06:46 Joe Perches j...@perches.com wrote: On Wed, 2015-04-29 at 21:32 +0200, Fabian Frederick wrote: typedef is not really useful here. Replace it by structure to improve readability.typedef should only be used in some cases. (See Documentation/CodingStyle Chapter 5

Re: [PATCH V2 linux-next] cpufreq: pxa: replace typedef pxa_freqs_t by structure

2015-04-30 Thread Rafael J. Wysocki
On Thursday, April 30, 2015 08:28:56 PM Fabian Frederick wrote: On 30 April 2015 at 06:46 Joe Perches j...@perches.com wrote: On Wed, 2015-04-29 at 21:32 +0200, Fabian Frederick wrote: typedef is not really useful here. Replace it by structure to improve readability.typedef should

Re: [PATCH V2 linux-next] cpufreq: pxa: replace typedef pxa_freqs_t by structure

2015-04-29 Thread Joe Perches
On Wed, 2015-04-29 at 21:32 +0200, Fabian Frederick wrote: > typedef is not really useful here. Replace it by structure > to improve readability.typedef should only be used in some cases. > (See Documentation/CodingStyle Chapter 5 for details). trivia: > diff --git

Re: [PATCH V2 linux-next] cpufreq: pxa: replace typedef pxa_freqs_t by structure

2015-04-29 Thread Viresh Kumar
On 30 April 2015 at 01:02, Fabian Frederick wrote: > typedef is not really useful here. Replace it by structure > to improve readability.typedef should only be used in some cases. Space after full stop. (Maybe Rafael can fix that while applying).. > (See Documentation/CodingStyle Chapter 5 for

[PATCH V2 linux-next] cpufreq: pxa: replace typedef pxa_freqs_t by structure

2015-04-29 Thread Fabian Frederick
typedef is not really useful here. Replace it by structure to improve readability.typedef should only be used in some cases. (See Documentation/CodingStyle Chapter 5 for details). Signed-off-by: Fabian Frederick --- V2: verbose changelog. drivers/cpufreq/pxa2xx-cpufreq.c | 20

[PATCH V2 linux-next] cpufreq: pxa: replace typedef pxa_freqs_t by structure

2015-04-29 Thread Fabian Frederick
typedef is not really useful here. Replace it by structure to improve readability.typedef should only be used in some cases. (See Documentation/CodingStyle Chapter 5 for details). Signed-off-by: Fabian Frederick f...@skynet.be --- V2: verbose changelog. drivers/cpufreq/pxa2xx-cpufreq.c | 20

Re: [PATCH V2 linux-next] cpufreq: pxa: replace typedef pxa_freqs_t by structure

2015-04-29 Thread Viresh Kumar
On 30 April 2015 at 01:02, Fabian Frederick f...@skynet.be wrote: typedef is not really useful here. Replace it by structure to improve readability.typedef should only be used in some cases. Space after full stop. (Maybe Rafael can fix that while applying).. (See Documentation/CodingStyle

Re: [PATCH V2 linux-next] cpufreq: pxa: replace typedef pxa_freqs_t by structure

2015-04-29 Thread Joe Perches
On Wed, 2015-04-29 at 21:32 +0200, Fabian Frederick wrote: typedef is not really useful here. Replace it by structure to improve readability.typedef should only be used in some cases. (See Documentation/CodingStyle Chapter 5 for details). trivia: diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c