Re: [PATCH V4 2/2] iio: light: isl29018: add optional vdd/vdda regulator operation support

2018-12-10 Thread Phil Reid
On 11/12/2018 12:29 pm, Anson Huang wrote: G'day Anson, Just pulled up the datasheet for this chip. The absolute max for Vdda is speced as Vddd ±0.5 With a note that Vdda should be externally shorted to Vddd. The data sheet says vdda should be connected to vdd externally, then I think we shou

RE: [PATCH V4 2/2] iio: light: isl29018: add optional vdd/vdda regulator operation support

2018-12-10 Thread Anson Huang
...@arm.com; linux-...@vger.kernel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; > feste...@gmail.com > Cc: dl-linux-imx > Subject: Re: [PATCH V4 2/2] iio: light: isl29018: add optional vdd/vdda > regulator operation support > > G'day Anson, > > Just pulled

Re: [PATCH V4 2/2] iio: light: isl29018: add optional vdd/vdda regulator operation support

2018-12-10 Thread Phil Reid
c: dl-linux-imx Subject: Re: [PATCH V4 2/2] iio: light: isl29018: add optional vdd/vdda regulator operation support On 11/12/2018 11:24 am, Anson Huang wrote: The light sensor's power supply could be controlled by regulator on some platforms, such as i.MX6Q-SABRESD board, the light sensor

RE: [PATCH V4 2/2] iio: light: isl29018: add optional vdd/vdda regulator operation support

2018-12-10 Thread Anson Huang
...@arm.com; linux-...@vger.kernel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; > feste...@gmail.com > Cc: dl-linux-imx > Subject: Re: [PATCH V4 2/2] iio: light: isl29018: add optional vdd/vdda > regulator operation support > > On 11/12/2018 11:24 am, Anson Huang wro

Re: [PATCH V4 2/2] iio: light: isl29018: add optional vdd/vdda regulator operation support

2018-12-10 Thread Phil Reid
On 11/12/2018 11:24 am, Anson Huang wrote: The light sensor's power supply could be controlled by regulator on some platforms, such as i.MX6Q-SABRESD board, the light sensor isl29023's power supply is controlled by a GPIO fixed regulator, need to make sure the regulator is enabled before any oper

[PATCH V4 2/2] iio: light: isl29018: add optional vdd/vdda regulator operation support

2018-12-10 Thread Anson Huang
The light sensor's power supply could be controlled by regulator on some platforms, such as i.MX6Q-SABRESD board, the light sensor isl29023's power supply is controlled by a GPIO fixed regulator, need to make sure the regulator is enabled before any operation of sensor, this patch adds optional vdd