Re: [PATCH V6] i2c: tegra: remove BUG, BUG_ON

2019-06-17 Thread Dmitry Osipenko
17.06.2019 22:08, Bitan Biswas пишет: > > > On 6/14/19 10:51 AM, Dmitry Osipenko wrote: >> 14.06.2019 18:50, Bitan Biswas пишет: >>> Remove redundant BUG_ON calls or replace with WARN_ON_ONCE >>> as needed. Remove BUG() and mask Rx interrupt similar as Tx >>> for message fully sent case. Add

Re: [PATCH V6] i2c: tegra: remove BUG, BUG_ON

2019-06-17 Thread Bitan Biswas
On 6/14/19 10:51 AM, Dmitry Osipenko wrote: 14.06.2019 18:50, Bitan Biswas пишет: Remove redundant BUG_ON calls or replace with WARN_ON_ONCE as needed. Remove BUG() and mask Rx interrupt similar as Tx for message fully sent case. Add WARN_ON_ONCE check for non-zero rx_fifo_avail in

Re: [PATCH V6] i2c: tegra: remove BUG, BUG_ON

2019-06-14 Thread Dmitry Osipenko
14.06.2019 18:50, Bitan Biswas пишет: > Remove redundant BUG_ON calls or replace with WARN_ON_ONCE > as needed. Remove BUG() and mask Rx interrupt similar as Tx > for message fully sent case. Add WARN_ON_ONCE check > for non-zero rx_fifo_avail in tegra_i2c_empty_rx_fifo() > after all processing.

[PATCH V6] i2c: tegra: remove BUG, BUG_ON

2019-06-14 Thread Bitan Biswas
Remove redundant BUG_ON calls or replace with WARN_ON_ONCE as needed. Remove BUG() and mask Rx interrupt similar as Tx for message fully sent case. Add WARN_ON_ONCE check for non-zero rx_fifo_avail in tegra_i2c_empty_rx_fifo() after all processing. Error handling in tegra_i2c_empty_rx_fifo caller