Re: [PATCH V7] i2c: tegra: remove BUG, BUG_ON

2019-06-17 Thread Bitan Biswas
On 6/17/19 12:28 PM, Dmitry Osipenko wrote: 17.06.2019 21:41, Bitan Biswas пишет: On 6/17/19 5:13 AM, Dmitry Osipenko wrote: 17.06.2019 8:09, Bitan Biswas пишет: Remove BUG, BUG_ON as it makes system usable:   - Remove redundant BUG_ON calls or replace with WARN_ON_ONCE     as needed.

Re: [PATCH V7] i2c: tegra: remove BUG, BUG_ON

2019-06-17 Thread Dmitry Osipenko
17.06.2019 21:41, Bitan Biswas пишет: > > > On 6/17/19 5:13 AM, Dmitry Osipenko wrote: >> 17.06.2019 8:09, Bitan Biswas пишет: >>> Remove BUG, BUG_ON as it makes system usable: >>>   - Remove redundant BUG_ON calls or replace with WARN_ON_ONCE >>>     as needed. >>>   - Remove BUG() and mask Rx i

Re: [PATCH V7] i2c: tegra: remove BUG, BUG_ON

2019-06-17 Thread Bitan Biswas
On 6/17/19 5:13 AM, Dmitry Osipenko wrote: 17.06.2019 8:09, Bitan Biswas пишет: Remove BUG, BUG_ON as it makes system usable: - Remove redundant BUG_ON calls or replace with WARN_ON_ONCE as needed. - Remove BUG() and mask Rx interrupt similar as Tx for message fully sent case. -

Re: [PATCH V7] i2c: tegra: remove BUG, BUG_ON

2019-06-17 Thread Dmitry Osipenko
17.06.2019 8:09, Bitan Biswas пишет: > Remove BUG, BUG_ON as it makes system usable: > - Remove redundant BUG_ON calls or replace with WARN_ON_ONCE >as needed. > - Remove BUG() and mask Rx interrupt similar as Tx >for message fully sent case. > - Add caller error handling and WARN_ON_ONC

[PATCH V7] i2c: tegra: remove BUG, BUG_ON

2019-06-16 Thread Bitan Biswas
Remove BUG, BUG_ON as it makes system usable: - Remove redundant BUG_ON calls or replace with WARN_ON_ONCE as needed. - Remove BUG() and mask Rx interrupt similar as Tx for message fully sent case. - Add caller error handling and WARN_ON_ONCE check for non-zero rx_fifo_avail in tegra_i2