Re: [PATCH lora-next] net: lora: sx1301: Fix radio SPI write

2018-12-31 Thread Mark Brown
On Mon, Dec 31, 2018 at 12:14:34AM +, Ben Whitten wrote: > If the regmap_bus provider does need to apply the mask, can we get the > end device regmap_config and apply it from there? > Mark what are your thoughts on the route to take? If you're getting a byte stream in then it'll have the mask

Re: [PATCH lora-next] net: lora: sx1301: Fix radio SPI write

2018-12-30 Thread Andreas Färber
Am 31.12.18 um 01:14 schrieb Ben Whitten: > + Mark +linux-kernel > On Sun, 30 Dec 2018 at 08:45, Andreas Färber wrote: >> >> When converting to regmap_bus we omitted the write flag, >> rendering all sx125x register writes no-op. >> >> Signed-off-by: Andreas Färber >> --- >> drivers/net/lora/sx13

Re: [PATCH lora-next] net: lora: sx1301: Fix radio SPI write

2018-12-30 Thread Ben Whitten
+ Mark +linux-kernel On Sun, 30 Dec 2018 at 08:45, Andreas Färber wrote: > > When converting to regmap_bus we omitted the write flag, > rendering all sx125x register writes no-op. > > Signed-off-by: Andreas Färber > --- > drivers/net/lora/sx130x_radio.c | 3 ++- > 1 file changed, 2 insertions(+)