Re: [PATCH net] net: phy: rtl8211f: do a double read to get real time link status

2019-08-11 Thread Yonglong Liu
On 2019/8/10 4:05, Heiner Kallweit wrote: > On 09.08.2019 06:57, Yonglong Liu wrote: >> >> >> On 2019/8/9 4:34, Andrew Lunn wrote: >>> On Thu, Aug 08, 2019 at 10:01:39PM +0200, Heiner Kallweit wrote: On 08.08.2019 21:40, Andrew Lunn wrote: >> @@ -568,6 +568,11 @@ int phy_start_aneg(stru

Re: [PATCH net] net: phy: rtl8211f: do a double read to get real time link status

2019-08-09 Thread Heiner Kallweit
On 09.08.2019 06:57, Yonglong Liu wrote: > > > On 2019/8/9 4:34, Andrew Lunn wrote: >> On Thu, Aug 08, 2019 at 10:01:39PM +0200, Heiner Kallweit wrote: >>> On 08.08.2019 21:40, Andrew Lunn wrote: > @@ -568,6 +568,11 @@ int phy_start_aneg(struct phy_device *phydev) > if (err < 0) >

Re: [PATCH net] net: phy: rtl8211f: do a double read to get real time link status

2019-08-08 Thread Yonglong Liu
On 2019/8/9 4:34, Andrew Lunn wrote: > On Thu, Aug 08, 2019 at 10:01:39PM +0200, Heiner Kallweit wrote: >> On 08.08.2019 21:40, Andrew Lunn wrote: @@ -568,6 +568,11 @@ int phy_start_aneg(struct phy_device *phydev) if (err < 0) goto out_unlock; + /* The P

Re: [PATCH net] net: phy: rtl8211f: do a double read to get real time link status

2019-08-08 Thread Andrew Lunn
On Thu, Aug 08, 2019 at 10:01:39PM +0200, Heiner Kallweit wrote: > On 08.08.2019 21:40, Andrew Lunn wrote: > >> @@ -568,6 +568,11 @@ int phy_start_aneg(struct phy_device *phydev) > >>if (err < 0) > >>goto out_unlock; > >> > >> + /* The PHY may not yet have cleared aneg-completed

Re: [PATCH net] net: phy: rtl8211f: do a double read to get real time link status

2019-08-08 Thread Heiner Kallweit
On 08.08.2019 21:40, Andrew Lunn wrote: >> @@ -568,6 +568,11 @@ int phy_start_aneg(struct phy_device *phydev) >> if (err < 0) >> goto out_unlock; >> >> +/* The PHY may not yet have cleared aneg-completed and link-up bit >> + * w/o this delay when the following read is do

Re: [PATCH net] net: phy: rtl8211f: do a double read to get real time link status

2019-08-08 Thread Andrew Lunn
> @@ -568,6 +568,11 @@ int phy_start_aneg(struct phy_device *phydev) > if (err < 0) > goto out_unlock; > > + /* The PHY may not yet have cleared aneg-completed and link-up bit > + * w/o this delay when the following read is done. > + */ > + usleep_range(1000,

Re: [PATCH net] net: phy: rtl8211f: do a double read to get real time link status

2019-08-08 Thread Heiner Kallweit
On 08.08.2019 08:21, Yonglong Liu wrote: > > > On 2019/8/8 14:11, Heiner Kallweit wrote: >> On 08.08.2019 03:15, Yonglong Liu wrote: >>> >>> >>> On 2019/8/8 0:47, Heiner Kallweit wrote: On 07.08.2019 15:16, Yonglong Liu wrote: > [ 27.232781] hns3 :bd:00.3 eth7: net open > [ 2

Re: [PATCH net] net: phy: rtl8211f: do a double read to get real time link status

2019-08-07 Thread Yonglong Liu
On 2019/8/8 14:11, Heiner Kallweit wrote: > On 08.08.2019 03:15, Yonglong Liu wrote: >> >> >> On 2019/8/8 0:47, Heiner Kallweit wrote: >>> On 07.08.2019 15:16, Yonglong Liu wrote: [ 27.232781] hns3 :bd:00.3 eth7: net open [ 27.237303] 8021q: adding VLAN 0 to HW filter on device

Re: [PATCH net] net: phy: rtl8211f: do a double read to get real time link status

2019-08-07 Thread Heiner Kallweit
On 08.08.2019 03:15, Yonglong Liu wrote: > > > On 2019/8/8 0:47, Heiner Kallweit wrote: >> On 07.08.2019 15:16, Yonglong Liu wrote: >>> [ 27.232781] hns3 :bd:00.3 eth7: net open >>> [ 27.237303] 8021q: adding VLAN 0 to HW filter on device eth7 >>> [ 27.242972] IPv6: ADDRCONF(NETDEV_CHAN

Re: [PATCH net] net: phy: rtl8211f: do a double read to get real time link status

2019-08-07 Thread Yonglong Liu
On 2019/8/8 0:47, Heiner Kallweit wrote: > On 07.08.2019 15:16, Yonglong Liu wrote: >> [ 27.232781] hns3 :bd:00.3 eth7: net open >> [ 27.237303] 8021q: adding VLAN 0 to HW filter on device eth7 >> [ 27.242972] IPv6: ADDRCONF(NETDEV_CHANGE): eth7: link becomes ready >> [ 27.29] hn

Re: [PATCH net] net: phy: rtl8211f: do a double read to get real time link status

2019-08-07 Thread Heiner Kallweit
On 07.08.2019 15:16, Yonglong Liu wrote: > [ 27.232781] hns3 :bd:00.3 eth7: net open > [ 27.237303] 8021q: adding VLAN 0 to HW filter on device eth7 > [ 27.242972] IPv6: ADDRCONF(NETDEV_CHANGE): eth7: link becomes ready > [ 27.29] hns3 :bd:00.3: invalid speed (-1) > [ 27.25390

[PATCH net] net: phy: rtl8211f: do a double read to get real time link status

2019-08-07 Thread Yonglong Liu
[ 27.232781] hns3 :bd:00.3 eth7: net open [ 27.237303] 8021q: adding VLAN 0 to HW filter on device eth7 [ 27.242972] IPv6: ADDRCONF(NETDEV_CHANGE): eth7: link becomes ready [ 27.29] hns3 :bd:00.3: invalid speed (-1) [ 27.253904] hns3 :bd:00.3 eth7: failed to adjust link. [