On Sun, 2013-12-29 at 23:05 +0100, Julia Lawall wrote:
> After some work on getting more include files to be taken into account, I
> get the following list of cases where both arguments have the form of a
> field reference, the field has array type, and the field is not at the end
> of the
> Hi Julia.
>
> Maybe this explanation is helpful?
>
> ethernet addresses are u8[6] (48 bits)
>
> ether_addr_equal_64bits gets passed a pointer to u8[8]
> and is more efficient on 64 bit architectures than
> ether_addr_equal because the test can be done with a
> single compare and shift.
>
>
Hi Julia.
Maybe this explanation is helpful?
ethernet addresses are u8[6] (48 bits)
ether_addr_equal_64bits gets passed a pointer to u8[8]
and is more efficient on 64 bit architectures than
ether_addr_equal because the test can be done with a
single compare and shift.
The idea is
On Sun, 2013-12-29 at 23:05 +0100, Julia Lawall wrote:
After some work on getting more include files to be taken into account, I
get the following list of cases where both arguments have the form of a
field reference, the field has array type, and the field is not at the end
of the
On 2013/12/28 13:11, Joe Perches wrote:
> On Sat, 2013-12-28 at 13:07 +0800, Ding Tianhong wrote:
>> On 2013/12/28 1:06, Joe Perches wrote:
>>> On Fri, 2013-12-27 at 07:48 -0800, Eric Dumazet wrote:
On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
> Use possibly more efficient
On Sat, 2013-12-28 at 13:07 +0800, Ding Tianhong wrote:
> On 2013/12/28 1:06, Joe Perches wrote:
> > On Fri, 2013-12-27 at 07:48 -0800, Eric Dumazet wrote:
> >> On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
> >>> Use possibly more efficient ether_addr_equal
> >>> to instead of memcmp.
>
On 2013/12/28 1:06, Joe Perches wrote:
> On Fri, 2013-12-27 at 07:48 -0800, Eric Dumazet wrote:
>> On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
>>> Use possibly more efficient ether_addr_equal
>>> to instead of memcmp.
> []
>>> diff --git a/drivers/net/plip/plip.c
On 2013/12/27 23:48, Eric Dumazet wrote:
> On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
>> Use possibly more efficient ether_addr_equal
>> to instead of memcmp.
>>
>> Cc: "David S. Miller"
>> Signed-off-by: Ding Tianhong
>> ---
>> drivers/net/plip/plip.c | 2 +-
>> 1 file changed, 1
> Hi Julia.
>
> Maybe this explanation is helpful?
>
> ethernet addresses are u8[6] (48 bits)
>
> ether_addr_equal_64bits gets passed a pointer to u8[8]
> and is more efficient on 64 bit architectures than
> ether_addr_equal because the test can be done with a
> single compare and shift.
>
>
On Fri, 2013-12-27 at 21:12 +0100, Julia Lawall wrote:
> On Fri, 27 Dec 2013, Joe Perches wrote:
>
> > On Fri, 2013-12-27 at 07:48 -0800, Eric Dumazet wrote:
> > > On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
> > > > Use possibly more efficient ether_addr_equal
> > > > to instead of
On Fri, 27 Dec 2013, Joe Perches wrote:
> On Fri, 2013-12-27 at 07:48 -0800, Eric Dumazet wrote:
> > On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
> > > Use possibly more efficient ether_addr_equal
> > > to instead of memcmp.
> []
> > > diff --git a/drivers/net/plip/plip.c
On Fri, 2013-12-27 at 07:48 -0800, Eric Dumazet wrote:
> On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
> > Use possibly more efficient ether_addr_equal
> > to instead of memcmp.
[]
> > diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c
[]
> > @@ -549,7 +549,7 @@ static __be16
On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
> Use possibly more efficient ether_addr_equal
> to instead of memcmp.
>
> Cc: "David S. Miller"
> Signed-off-by: Ding Tianhong
> ---
> drivers/net/plip/plip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/plip/plip.c | 2 +-
1 file changed, 1 insertion(+), 1
On Fri, 2013-12-27 at 07:48 -0800, Eric Dumazet wrote:
On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
to instead of memcmp.
[]
diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c
[]
@@ -549,7 +549,7 @@ static __be16
On Fri, 27 Dec 2013, Joe Perches wrote:
On Fri, 2013-12-27 at 07:48 -0800, Eric Dumazet wrote:
On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
to instead of memcmp.
[]
diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c
On Fri, 2013-12-27 at 21:12 +0100, Julia Lawall wrote:
On Fri, 27 Dec 2013, Joe Perches wrote:
On Fri, 2013-12-27 at 07:48 -0800, Eric Dumazet wrote:
On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
to instead of memcmp.
[]
Hi Julia.
Maybe this explanation is helpful?
ethernet addresses are u8[6] (48 bits)
ether_addr_equal_64bits gets passed a pointer to u8[8]
and is more efficient on 64 bit architectures than
ether_addr_equal because the test can be done with a
single compare and shift.
The idea is
On 2013/12/27 23:48, Eric Dumazet wrote:
On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/plip/plip.c | 2
On 2013/12/28 1:06, Joe Perches wrote:
On Fri, 2013-12-27 at 07:48 -0800, Eric Dumazet wrote:
On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
to instead of memcmp.
[]
diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c
[]
@@
On Sat, 2013-12-28 at 13:07 +0800, Ding Tianhong wrote:
On 2013/12/28 1:06, Joe Perches wrote:
On Fri, 2013-12-27 at 07:48 -0800, Eric Dumazet wrote:
On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
to instead of memcmp.
[]
diff
On 2013/12/28 13:11, Joe Perches wrote:
On Sat, 2013-12-28 at 13:07 +0800, Ding Tianhong wrote:
On 2013/12/28 1:06, Joe Perches wrote:
On Fri, 2013-12-27 at 07:48 -0800, Eric Dumazet wrote:
On Fri, 2013-12-27 at 14:49 +0800, Ding Tianhong wrote:
Use possibly more efficient ether_addr_equal
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: "David S. Miller"
Signed-off-by: Ding Tianhong
---
drivers/net/plip/plip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/plip/plip.c b/drivers/net/plip/plip.c
index 7b4ff35..26614df 100644
Use possibly more efficient ether_addr_equal
to instead of memcmp.
Cc: David S. Miller da...@davemloft.net
Signed-off-by: Ding Tianhong dingtianh...@huawei.com
---
drivers/net/plip/plip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/plip/plip.c
24 matches
Mail list logo
