Re: [PATCH net-next 3/5] net: dsa: add CPU and DSA ports as VLAN members

2017-06-07 Thread Florian Fainelli
On 06/06/2017 01:56 PM, Vivien Didelot wrote: > In a multi-chip switch fabric, it is currently the responsibility of the > driver to add the CPU or DSA (interconnecting chips together) ports as > members of a new VLAN entry. This makes the drivers more complicated. > > We want the DSA drivers to

Re: [PATCH net-next 3/5] net: dsa: add CPU and DSA ports as VLAN members

2017-06-07 Thread Florian Fainelli
On 06/06/2017 01:56 PM, Vivien Didelot wrote: > In a multi-chip switch fabric, it is currently the responsibility of the > driver to add the CPU or DSA (interconnecting chips together) ports as > members of a new VLAN entry. This makes the drivers more complicated. > > We want the DSA drivers to

Re: [PATCH net-next 3/5] net: dsa: add CPU and DSA ports as VLAN members

2017-06-07 Thread David Miller
From: Vivien Didelot Date: Tue, 6 Jun 2017 16:56:29 -0400 > @@ -166,6 +166,9 @@ static int dsa_switch_vlan_add(struct dsa_switch *ds, > bitmap_zero(members, ds->num_ports); > if (ds->index == info->sw_index) > set_bit(info->port,

Re: [PATCH net-next 3/5] net: dsa: add CPU and DSA ports as VLAN members

2017-06-07 Thread David Miller
From: Vivien Didelot Date: Tue, 6 Jun 2017 16:56:29 -0400 > @@ -166,6 +166,9 @@ static int dsa_switch_vlan_add(struct dsa_switch *ds, > bitmap_zero(members, ds->num_ports); > if (ds->index == info->sw_index) > set_bit(info->port, members); > + for (port = 0; port <

[PATCH net-next 3/5] net: dsa: add CPU and DSA ports as VLAN members

2017-06-06 Thread Vivien Didelot
In a multi-chip switch fabric, it is currently the responsibility of the driver to add the CPU or DSA (interconnecting chips together) ports as members of a new VLAN entry. This makes the drivers more complicated. We want the DSA drivers to be stupid and the DSA core being the one responsible for

[PATCH net-next 3/5] net: dsa: add CPU and DSA ports as VLAN members

2017-06-06 Thread Vivien Didelot
In a multi-chip switch fabric, it is currently the responsibility of the driver to add the CPU or DSA (interconnecting chips together) ports as members of a new VLAN entry. This makes the drivers more complicated. We want the DSA drivers to be stupid and the DSA core being the one responsible for