Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-19 Thread Jiri Pirko
Wed, Aug 19, 2020 at 06:25:51PM CEST, k...@kernel.org wrote: >On Wed, 19 Aug 2020 17:18:15 +0200 Jiri Pirko wrote: > I will add counters on which reload were done. reload_down()/up() can > return > which actions were actually done and devlink will show counters. Why a counter?

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-19 Thread Jakub Kicinski
On Wed, 19 Aug 2020 17:18:15 +0200 Jiri Pirko wrote: I will add counters on which reload were done. reload_down()/up() can return which actions were actually done and devlink will show counters. >>> Why a counter? Just return what was done over netlink reply. >> >> Such

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-19 Thread Jiri Pirko
Wed, Aug 19, 2020 at 04:23:25PM CEST, mo...@nvidia.com wrote: > >On 8/19/2020 3:46 PM, Jiri Pirko wrote: >> Wed, Aug 19, 2020 at 02:18:22PM CEST, mo...@nvidia.com wrote: >> > On 8/19/2020 3:10 AM, Jakub Kicinski wrote: >> > > On Tue, 18 Aug 2020 12:10:36 +0300 Moshe Shemesh wrote: >> > > > On

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-19 Thread Moshe Shemesh
On 8/19/2020 3:46 PM, Jiri Pirko wrote: Wed, Aug 19, 2020 at 02:18:22PM CEST, mo...@nvidia.com wrote: On 8/19/2020 3:10 AM, Jakub Kicinski wrote: On Tue, 18 Aug 2020 12:10:36 +0300 Moshe Shemesh wrote: On 8/17/2020 7:36 PM, Jiri Pirko wrote: Mon, Aug 17, 2020 at 11:37:40AM CEST,

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-19 Thread Jiri Pirko
Wed, Aug 19, 2020 at 02:18:22PM CEST, mo...@nvidia.com wrote: > >On 8/19/2020 3:10 AM, Jakub Kicinski wrote: >> >> On Tue, 18 Aug 2020 12:10:36 +0300 Moshe Shemesh wrote: >> > On 8/17/2020 7:36 PM, Jiri Pirko wrote: >> > > Mon, Aug 17, 2020 at 11:37:40AM CEST, mo...@mellanox.com wrote: >> > > >

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-19 Thread Moshe Shemesh
On 8/19/2020 3:10 AM, Jakub Kicinski wrote: On Tue, 18 Aug 2020 12:10:36 +0300 Moshe Shemesh wrote: On 8/17/2020 7:36 PM, Jiri Pirko wrote: Mon, Aug 17, 2020 at 11:37:40AM CEST, mo...@mellanox.com wrote: Add devlink reload action to allow the user to request a specific reload action. The

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-18 Thread Jakub Kicinski
On Tue, 18 Aug 2020 12:10:36 +0300 Moshe Shemesh wrote: > On 8/17/2020 7:36 PM, Jiri Pirko wrote: > > Mon, Aug 17, 2020 at 11:37:40AM CEST, mo...@mellanox.com wrote: > >> Add devlink reload action to allow the user to request a specific reload > >> action. The action parameter is optional, if

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-18 Thread Jakub Kicinski
On Tue, 18 Aug 2020 12:06:13 +0300 Moshe Shemesh wrote: > Or maybe better than "live" say explicitly "no reset": > >     devlink dev reload DEV [ netns { PID | NAME | ID } ] [ action { > driver_reinit | fw_activate [--no_reset] } ] SGTM

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-18 Thread Moshe Shemesh
On 8/17/2020 7:36 PM, Jiri Pirko wrote: Mon, Aug 17, 2020 at 11:37:40AM CEST, mo...@mellanox.com wrote: Add devlink reload action to allow the user to request a specific reload action. The action parameter is optional, if not specified then devlink driver re-init action is used (backward

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-18 Thread Moshe Shemesh
On 8/17/2020 7:16 PM, Jakub Kicinski wrote: On Mon, 17 Aug 2020 12:37:40 +0300 Moshe Shemesh wrote: Add devlink reload action to allow the user to request a specific reload action. The action parameter is optional, if not specified then devlink driver re-init action is used (backward

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-17 Thread Jakub Kicinski
On Mon, 17 Aug 2020 12:37:40 +0300 Moshe Shemesh wrote: > Add devlink reload action to allow the user to request a specific reload > action. The action parameter is optional, if not specified then devlink > driver re-init action is used (backward compatible). > Note that when required to do

Re: [PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-17 Thread Jiri Pirko
Mon, Aug 17, 2020 at 11:37:40AM CEST, mo...@mellanox.com wrote: >Add devlink reload action to allow the user to request a specific reload >action. The action parameter is optional, if not specified then devlink >driver re-init action is used (backward compatible). >Note that when required to do

[PATCH net-next RFC v2 01/13] devlink: Add reload action option to devlink reload command

2020-08-17 Thread Moshe Shemesh
Add devlink reload action to allow the user to request a specific reload action. The action parameter is optional, if not specified then devlink driver re-init action is used (backward compatible). Note that when required to do firmware activation some drivers may need to reload the driver. On the