Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-10 Thread Jiri Pirko
Wed, Sep 09, 2020 at 03:27:19PM CEST, mo...@nvidia.com wrote: > >On 9/7/2020 8:58 PM, Jakub Kicinski wrote: >> On Mon, 7 Sep 2020 16:46:01 +0300 Moshe Shemesh wrote: >> > > In that sense I don't like --live because it doesn't really say much. >> > > AFAIU it means 1) no link flap; 2) < 2 sec

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-09 Thread Vasundhara Volam
On Wed, Sep 9, 2020 at 10:51 PM Moshe Shemesh wrote: > > > On 9/7/2020 8:58 PM, Jakub Kicinski wrote: > > On Mon, 7 Sep 2020 16:46:01 +0300 Moshe Shemesh wrote: > >>> In that sense I don't like --live because it doesn't really say much. > >>> AFAIU it means 1) no link flap; 2) < 2 sec datapath

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-09 Thread Jakub Kicinski
On Wed, 9 Sep 2020 16:27:19 +0300 Moshe Shemesh wrote: > On 9/7/2020 8:58 PM, Jakub Kicinski wrote: > > On Mon, 7 Sep 2020 16:46:01 +0300 Moshe Shemesh wrote: > >>> In that sense I don't like --live because it doesn't really say much. > >>> AFAIU it means 1) no link flap; 2) < 2 sec datapath

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-09 Thread Moshe Shemesh
On 9/7/2020 8:58 PM, Jakub Kicinski wrote: On Mon, 7 Sep 2020 16:46:01 +0300 Moshe Shemesh wrote: In that sense I don't like --live because it doesn't really say much. AFAIU it means 1) no link flap; 2) < 2 sec datapath downtime; 3) no configuration is lost in kernel or device (including

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-07 Thread Jakub Kicinski
On Mon, 7 Sep 2020 16:46:01 +0300 Moshe Shemesh wrote: > > In that sense I don't like --live because it doesn't really say much. > > AFAIU it means 1) no link flap; 2) < 2 sec datapath downtime; 3) no > > configuration is lost in kernel or device (including netdev config, > > link config, flow

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-07 Thread Moshe Shemesh
On 9/4/2020 10:56 PM, Jakub Kicinski wrote: External email: Use caution opening links or attachments On Fri, 4 Sep 2020 11:04:50 +0200 Jiri Pirko wrote: Thu, Sep 03, 2020 at 09:47:19PM CEST, k...@kernel.org wrote: On Thu, 3 Sep 2020 07:57:29 +0200 Jiri Pirko wrote: Wed, Sep 02, 2020 at

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-04 Thread Jakub Kicinski
On Fri, 4 Sep 2020 11:04:50 +0200 Jiri Pirko wrote: > Thu, Sep 03, 2020 at 09:47:19PM CEST, k...@kernel.org wrote: > >On Thu, 3 Sep 2020 07:57:29 +0200 Jiri Pirko wrote: > >> Wed, Sep 02, 2020 at 05:30:25PM CEST, k...@kernel.org wrote: > >> >On Wed, 2 Sep 2020 11:46:27 +0200 Jiri Pirko wrote:

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-04 Thread Jiri Pirko
Thu, Sep 03, 2020 at 09:47:19PM CEST, k...@kernel.org wrote: >On Thu, 3 Sep 2020 07:57:29 +0200 Jiri Pirko wrote: >> Wed, Sep 02, 2020 at 05:30:25PM CEST, k...@kernel.org wrote: >> >On Wed, 2 Sep 2020 11:46:27 +0200 Jiri Pirko wrote: >> >> >? Do we need such change there too or keep it as is,

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-03 Thread Jakub Kicinski
On Thu, 3 Sep 2020 07:57:29 +0200 Jiri Pirko wrote: > Wed, Sep 02, 2020 at 05:30:25PM CEST, k...@kernel.org wrote: > >On Wed, 2 Sep 2020 11:46:27 +0200 Jiri Pirko wrote: > >> >? Do we need such change there too or keep it as is, each action by itself > >> >and return what was performed ? >

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-02 Thread Jiri Pirko
Wed, Sep 02, 2020 at 05:30:25PM CEST, k...@kernel.org wrote: >On Wed, 2 Sep 2020 11:46:27 +0200 Jiri Pirko wrote: >> >? Do we need such change there too or keep it as is, each action by itself >> >and return what was performed ? >> >> Well, I don't know. User asks for X, X should be performed,

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-02 Thread Jakub Kicinski
On Wed, 2 Sep 2020 11:46:27 +0200 Jiri Pirko wrote: > >? Do we need such change there too or keep it as is, each action by itself > >and return what was performed ? > > Well, I don't know. User asks for X, X should be performed, not Y or Z. > So perhaps the return value is not needed. > Just

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-02 Thread Jiri Pirko
Tue, Sep 01, 2020 at 09:43:00PM CEST, mo...@nvidia.com wrote: > >On 8/31/2020 3:15 PM, Jiri Pirko wrote: >> Sun, Aug 30, 2020 at 05:27:21PM CEST, mo...@mellanox.com wrote: >> > Add devlink reload action to allow the user to request a specific reload >> > action. The action parameter is optional,

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-01 Thread Moshe Shemesh
On 8/31/2020 3:15 PM, Jiri Pirko wrote: Sun, Aug 30, 2020 at 05:27:21PM CEST, mo...@mellanox.com wrote: Add devlink reload action to allow the user to request a specific reload action. The action parameter is optional, if not specified then devlink driver re-init action is used (backward

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-08-31 Thread Jiri Pirko
Sun, Aug 30, 2020 at 05:27:21PM CEST, mo...@mellanox.com wrote: >Add devlink reload action to allow the user to request a specific reload >action. The action parameter is optional, if not specified then devlink >driver re-init action is used (backward compatible). >Note that when required to do

[PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-08-30 Thread Moshe Shemesh
Add devlink reload action to allow the user to request a specific reload action. The action parameter is optional, if not specified then devlink driver re-init action is used (backward compatible). Note that when required to do firmware activation some drivers may need to reload the driver. On the