Re: [PATCH net-next v2 1/2] hinic: add rss support

2019-06-13 Thread Jakub Kicinski
On Tue, 11 Jun 2019 18:12:33 +, Xue Chaojing wrote: > + for (i = 0; i < HINIC_RSS_INDIR_SIZE; i++) > + indir_tbl[i] = (i / HINIC_RSS_INDIR_SIZE) * nic_dev->num_rss + > + i % nic_dev->num_rss; This looks suspicious: i is in range [0,

Re: [PATCH net-next v2 1/2] hinic: add rss support

2019-06-13 Thread Jakub Kicinski
On Tue, 11 Jun 2019 18:12:33 +, Xue Chaojing wrote: > This patch adds rss support for the HINIC driver. > > Signed-off-by: Xue Chaojing > +static int hinic_rss_init(struct hinic_dev *nic_dev) > +{ > + u8 default_rss_key[HINIC_RSS_KEY_SIZE] = { > + 0x6d, 0x5a, 0x56,

Re: [PATCH net-next v2 1/2] hinic: add rss support

2019-06-13 Thread xuechaojing
Hi UDP RSS is supported on hinic device, so we set udp rss type to 1. Thanks for reviewing. xue 在 2019/6/13 6:56, Jakub Kicinski wrote: On Tue, 11 Jun 2019 18:12:33 +, Xue Chaojing wrote: This patch adds rss support for the HINIC driver. Signed-off-by: Xue Chaojing +static int

[PATCH net-next v2 1/2] hinic: add rss support

2019-06-11 Thread Xue Chaojing
This patch adds rss support for the HINIC driver. Signed-off-by: Xue Chaojing --- drivers/net/ethernet/huawei/hinic/hinic_dev.h | 26 ++ .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 10 +- .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 26 ++ .../net/ethernet/huawei/hinic/hinic_hw_wqe.h