Re: [PATCH net-next v6 4/4] net: dp83869: Add RGMII internal delay configuration

2020-06-04 Thread kernel test robot
Hi Dan, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on robh/for-next sparc-next/master net/master linus/master v5.7 next-20200604] [if your patch is applied to the wrong git tree, please drop us a note to help improve the

Re: [PATCH net-next v6 4/4] net: dp83869: Add RGMII internal delay configuration

2020-06-04 Thread Dan Murphy
Jakub On 6/4/20 11:48 AM, Jakub Kicinski wrote: On Thu, 4 Jun 2020 11:38:14 -0500 Dan Murphy wrote: Jakub On 6/4/20 11:25 AM, Jakub Kicinski wrote: On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote: Add RGMII internal delay configuration for Rx and Tx. Signed-off-by: Dan Murphy Hi Dan, p

Re: [PATCH net-next v6 4/4] net: dp83869: Add RGMII internal delay configuration

2020-06-04 Thread Jakub Kicinski
On Thu, 4 Jun 2020 11:38:14 -0500 Dan Murphy wrote: > Jakub > > On 6/4/20 11:25 AM, Jakub Kicinski wrote: > > On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote: > >> Add RGMII internal delay configuration for Rx and Tx. > >> > >> Signed-off-by: Dan Murphy > > Hi Dan, please make sure W=1 C=1

Re: [PATCH net-next v6 4/4] net: dp83869: Add RGMII internal delay configuration

2020-06-04 Thread Dan Murphy
Jakub On 6/4/20 11:25 AM, Jakub Kicinski wrote: On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote: Add RGMII internal delay configuration for Rx and Tx. Signed-off-by: Dan Murphy Hi Dan, please make sure W=1 C=1 build is clean: drivers/net/phy/dp83869.c:103:18: warning: ‘dp83869_internal

Re: [PATCH net-next v6 4/4] net: dp83869: Add RGMII internal delay configuration

2020-06-04 Thread Jakub Kicinski
On Thu, 4 Jun 2020 06:14:10 -0500 Dan Murphy wrote: > Add RGMII internal delay configuration for Rx and Tx. > > Signed-off-by: Dan Murphy Hi Dan, please make sure W=1 C=1 build is clean: drivers/net/phy/dp83869.c:103:18: warning: ‘dp83869_internal_delay’ defined but not used [-Wunused-cons

[PATCH net-next v6 4/4] net: dp83869: Add RGMII internal delay configuration

2020-06-04 Thread Dan Murphy
Add RGMII internal delay configuration for Rx and Tx. Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c | 53 --- 1 file changed, 50 insertions(+), 3 deletions(-) diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c index cfb22a21a2e6..801