Re: [PATCH net-next v7 13/17] ethtool: add standard notification handler

2019-10-10 Thread Michal Kubecek
On Friday, 11 October 2019 7:56 Jiri Pirko wrote: > Thu, Oct 10, 2019 at 08:17:43PM CEST, mkube...@suse.cz wrote: > >On Thu, Oct 10, 2019 at 05:25:59PM +0200, Jiri Pirko wrote: > >> Wed, Oct 09, 2019 at 10:59:40PM CEST, mkube...@suse.cz wrote: > [...] > > >> >+ > >> >+/* generic notification

Re: [PATCH net-next v7 13/17] ethtool: add standard notification handler

2019-10-10 Thread Jiri Pirko
Thu, Oct 10, 2019 at 08:17:43PM CEST, mkube...@suse.cz wrote: >On Thu, Oct 10, 2019 at 05:25:59PM +0200, Jiri Pirko wrote: >> Wed, Oct 09, 2019 at 10:59:40PM CEST, mkube...@suse.cz wrote: [...] >> >+ >> >+/* generic notification handler */ >> >+static void ethnl_std_notify(struct net_device

Re: [PATCH net-next v7 13/17] ethtool: add standard notification handler

2019-10-10 Thread Michal Kubecek
On Thu, Oct 10, 2019 at 05:25:59PM +0200, Jiri Pirko wrote: > Wed, Oct 09, 2019 at 10:59:40PM CEST, mkube...@suse.cz wrote: > >+static void *ethnl_bcastmsg_put(struct sk_buff *skb, u8 cmd) > >+{ > >+return genlmsg_put(skb, 0, ++ethnl_bcast_seq, _genl_family, 0, > >+ cmd);

Re: [PATCH net-next v7 13/17] ethtool: add standard notification handler

2019-10-10 Thread Jiri Pirko
Wed, Oct 09, 2019 at 10:59:40PM CEST, mkube...@suse.cz wrote: >The ethtool netlink notifications have the same format as related GET >replies so that if generic GET handling framework is used to process GET >requests, its callbacks and instance of struct get_request_ops can be >also used to

[PATCH net-next v7 13/17] ethtool: add standard notification handler

2019-10-09 Thread Michal Kubecek
The ethtool netlink notifications have the same format as related GET replies so that if generic GET handling framework is used to process GET requests, its callbacks and instance of struct get_request_ops can be also used to compose corresponding notification message. Provide function