Re: [PATCH net 1/2] tun: unbreak truncated packet signalling

2013-12-09 Thread Jason Wang
On 12/09/2013 11:31 PM, Vlad Yasevich wrote: > On 12/09/2013 05:55 AM, Michael S. Tsirkin wrote: >> On Mon, Dec 09, 2013 at 06:25:16PM +0800, Jason Wang wrote: >>> Commit 6680ec68eff47d36f67b4351bc9836fd6cba9532 >>> (tuntap: hardware vlan tx support) breaks the truncated packet signal > by never >>

Re: [PATCH net 1/2] tun: unbreak truncated packet signalling

2013-12-09 Thread Jason Wang
On 12/09/2013 06:56 PM, Michael S. Tsirkin wrote: > On Mon, Dec 09, 2013 at 12:55:29PM +0200, Michael S. Tsirkin wrote: >> On Mon, Dec 09, 2013 at 06:25:16PM +0800, Jason Wang wrote: >>> Commit 6680ec68eff47d36f67b4351bc9836fd6cba9532 >>> (tuntap: hardware vlan tx support) breaks the truncated pack

Re: [PATCH net 1/2] tun: unbreak truncated packet signalling

2013-12-09 Thread Vlad Yasevich
On 12/09/2013 05:55 AM, Michael S. Tsirkin wrote: > On Mon, Dec 09, 2013 at 06:25:16PM +0800, Jason Wang wrote: >> Commit 6680ec68eff47d36f67b4351bc9836fd6cba9532 >> (tuntap: hardware vlan tx support) breaks the truncated packet signal by never >> return a length greater than iov length in tun_put_

Re: [PATCH net 1/2] tun: unbreak truncated packet signalling

2013-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 12:55:29PM +0200, Michael S. Tsirkin wrote: > On Mon, Dec 09, 2013 at 06:25:16PM +0800, Jason Wang wrote: > > Commit 6680ec68eff47d36f67b4351bc9836fd6cba9532 > > (tuntap: hardware vlan tx support) breaks the truncated packet signal by > > never > > return a length greater t

Re: [PATCH net 1/2] tun: unbreak truncated packet signalling

2013-12-09 Thread Michael S. Tsirkin
On Mon, Dec 09, 2013 at 06:25:16PM +0800, Jason Wang wrote: > Commit 6680ec68eff47d36f67b4351bc9836fd6cba9532 > (tuntap: hardware vlan tx support) breaks the truncated packet signal by never > return a length greater than iov length in tun_put_user(). This patch fixes > this > by always return the

[PATCH net 1/2] tun: unbreak truncated packet signalling

2013-12-09 Thread Jason Wang
Commit 6680ec68eff47d36f67b4351bc9836fd6cba9532 (tuntap: hardware vlan tx support) breaks the truncated packet signal by never return a length greater than iov length in tun_put_user(). This patch fixes this by always return the length of packet plus possible vlan header. Caller can detect the trun