Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-11 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 09, 2015 at 10:41:38AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: > > General refcnt miscodings > > = > > > > BTW, while applying this change, I've found that there are refcnt > > coding

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-11 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 09, 2015 at 10:41:38AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: > > General refcnt miscodings > > = > > > > BTW, while applying this change, I've found that there are refcnt > > coding

RE: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread 平松雅巳 / HIRAMATU,MASAMI
From: Wangnan (F) [mailto:wangn...@huawei.com] > > >On 2015/12/11 10:15, 平松雅巳 / HIRAMATU,MASAMI wrote: >> From: 'Arnaldo Carvalho de Melo' [mailto:a...@kernel.org] >>> But this requires having these special refcnt__ routines, that will make >>> tools/perf/ code patterns for reference counts look

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread Wangnan (F)
On 2015/12/11 10:42, Wangnan (F) wrote: On 2015/12/11 10:15, 平松雅巳 / HIRAMATU,MASAMI wrote: From: 'Arnaldo Carvalho de Melo' [mailto:a...@kernel.org] But this requires having these special refcnt__ routines, that will make tools/perf/ code patterns for reference counts look different that

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread Wangnan (F)
On 2015/12/11 10:15, 平松雅巳 / HIRAMATU,MASAMI wrote: From: 'Arnaldo Carvalho de Melo' [mailto:a...@kernel.org] But this requires having these special refcnt__ routines, that will make tools/perf/ code patterns for reference counts look different that the refcount patterns in the kernel :-\

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread Wangnan (F)
On 2015/12/11 10:08, 平松雅巳 / HIRAMATU,MASAMI wrote: From: Wangnan (F) [mailto:wangn...@huawei.com] On 2015/12/10 23:12, 'Arnaldo Carvalho de Melo' wrote: [SNIP] But this requires having these special refcnt__ routines, that will make tools/perf/ code patterns for reference counts look

RE: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread 平松雅巳 / HIRAMATU,MASAMI
From: 'Arnaldo Carvalho de Melo' [mailto:a...@kernel.org] > >But this requires having these special refcnt__ routines, that will make >tools/perf/ code patterns for reference counts look different that the >refcount patterns in the kernel :-\ BTW, I think even without the refcnt debugger, we'd

RE: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread 平松雅巳 / HIRAMATU,MASAMI
From: Wangnan (F) [mailto:wangn...@huawei.com] >On 2015/12/10 23:12, 'Arnaldo Carvalho de Melo' wrote: > >[SNIP] >> But this requires having these special refcnt__ routines, that will make >> tools/perf/ code patterns for reference counts look different that the >> refcount patterns in the kernel

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread Wangnan (F)
On 2015/12/10 23:12, 'Arnaldo Carvalho de Melo' wrote: [SNIP] But this requires having these special refcnt__ routines, that will make tools/perf/ code patterns for reference counts look different that the refcount patterns in the kernel :-\ And would be a requirement to change the observed

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread 'Arnaldo Carvalho de Melo'
Em Thu, Dec 10, 2015 at 08:52:02PM +0800, Wangnan (F) escreveu: > On 2015/12/10 19:04, 平松雅巳 / HIRAMATU,MASAMI wrote: > >>From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] > >>Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: > >>>Here is a series of patches for perf refcnt

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread Wangnan (F)
On 2015/12/10 19:04, 平松雅巳 / HIRAMATU,MASAMI wrote: From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: Hi Arnaldo, Here is a series of patches for perf refcnt debugger and some fixes. In this series I've replaced all

RE: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread 平松雅巳 / HIRAMATU,MASAMI
>From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] > >Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: >> Hi Arnaldo, >> >> Here is a series of patches for perf refcnt debugger and >> some fixes. >> >> In this series I've replaced all atomic reference counters >> with the

RE: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread 平松雅巳 / HIRAMATU,MASAMI
>From: Namhyung Kim [mailto:namhy...@kernel.org] > >Hi Arnaldo and Masami, > >On Wed, Dec 09, 2015 at 10:41:38AM -0300, Arnaldo Carvalho de Melo wrote: >> Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: >> > In this series I've also tried to fix some object leaks in perf top

RE: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread 平松雅巳 / HIRAMATU,MASAMI
>From: Namhyung Kim [mailto:namhy...@kernel.org] > >Hi Arnaldo and Masami, > >On Wed, Dec 09, 2015 at 10:41:38AM -0300, Arnaldo Carvalho de Melo wrote: >> Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: >> > In this series I've also tried to fix some object leaks in perf top

RE: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread 平松雅巳 / HIRAMATU,MASAMI
>From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] > >Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: >> Hi Arnaldo, >> >> Here is a series of patches for perf refcnt debugger and >> some fixes. >> >> In this series I've replaced all atomic reference counters >> with the

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread Wangnan (F)
On 2015/12/10 23:12, 'Arnaldo Carvalho de Melo' wrote: [SNIP] But this requires having these special refcnt__ routines, that will make tools/perf/ code patterns for reference counts look different that the refcount patterns in the kernel :-\ And would be a requirement to change the observed

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread Wangnan (F)
On 2015/12/11 10:15, 平松雅巳 / HIRAMATU,MASAMI wrote: From: 'Arnaldo Carvalho de Melo' [mailto:a...@kernel.org] But this requires having these special refcnt__ routines, that will make tools/perf/ code patterns for reference counts look different that the refcount patterns in the kernel :-\

RE: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread 平松雅巳 / HIRAMATU,MASAMI
From: 'Arnaldo Carvalho de Melo' [mailto:a...@kernel.org] > >But this requires having these special refcnt__ routines, that will make >tools/perf/ code patterns for reference counts look different that the >refcount patterns in the kernel :-\ BTW, I think even without the refcnt debugger, we'd

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread Wangnan (F)
On 2015/12/11 10:42, Wangnan (F) wrote: On 2015/12/11 10:15, 平松雅巳 / HIRAMATU,MASAMI wrote: From: 'Arnaldo Carvalho de Melo' [mailto:a...@kernel.org] But this requires having these special refcnt__ routines, that will make tools/perf/ code patterns for reference counts look different that

RE: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread 平松雅巳 / HIRAMATU,MASAMI
From: Wangnan (F) [mailto:wangn...@huawei.com] > > >On 2015/12/11 10:15, 平松雅巳 / HIRAMATU,MASAMI wrote: >> From: 'Arnaldo Carvalho de Melo' [mailto:a...@kernel.org] >>> But this requires having these special refcnt__ routines, that will make >>> tools/perf/ code patterns for reference counts look

RE: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread 平松雅巳 / HIRAMATU,MASAMI
From: Wangnan (F) [mailto:wangn...@huawei.com] >On 2015/12/10 23:12, 'Arnaldo Carvalho de Melo' wrote: > >[SNIP] >> But this requires having these special refcnt__ routines, that will make >> tools/perf/ code patterns for reference counts look different that the >> refcount patterns in the kernel

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread Wangnan (F)
On 2015/12/11 10:08, 平松雅巳 / HIRAMATU,MASAMI wrote: From: Wangnan (F) [mailto:wangn...@huawei.com] On 2015/12/10 23:12, 'Arnaldo Carvalho de Melo' wrote: [SNIP] But this requires having these special refcnt__ routines, that will make tools/perf/ code patterns for reference counts look

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread Wangnan (F)
On 2015/12/10 19:04, 平松雅巳 / HIRAMATU,MASAMI wrote: From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: Hi Arnaldo, Here is a series of patches for perf refcnt debugger and some fixes. In this series I've replaced all

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-10 Thread 'Arnaldo Carvalho de Melo'
Em Thu, Dec 10, 2015 at 08:52:02PM +0800, Wangnan (F) escreveu: > On 2015/12/10 19:04, 平松雅巳 / HIRAMATU,MASAMI wrote: > >>From: Arnaldo Carvalho de Melo [mailto:a...@kernel.org] > >>Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: > >>>Here is a series of patches for perf refcnt

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-09 Thread Namhyung Kim
Hi Arnaldo and Masami, On Wed, Dec 09, 2015 at 10:41:38AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: > > In this series I've also tried to fix some object leaks in perf top > > and perf stat. > > After applying this series, this

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-09 Thread Alexei Starovoitov
On Wed, Dec 09, 2015 at 10:41:38AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: > > Hi Arnaldo, > > > > Here is a series of patches for perf refcnt debugger and > > some fixes. > > > > In this series I've replaced all atomic

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-09 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: > Hi Arnaldo, > > Here is a series of patches for perf refcnt debugger and > some fixes. > > In this series I've replaced all atomic reference counters > with the refcnt interface, including dso, map, map_groups, > thread,

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-09 Thread Arnaldo Carvalho de Melo
Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: > Hi Arnaldo, > > Here is a series of patches for perf refcnt debugger and > some fixes. > > In this series I've replaced all atomic reference counters > with the refcnt interface, including dso, map, map_groups, > thread,

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-09 Thread Namhyung Kim
Hi Arnaldo and Masami, On Wed, Dec 09, 2015 at 10:41:38AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: > > In this series I've also tried to fix some object leaks in perf top > > and perf stat. > > After applying this series, this

Re: [PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-09 Thread Alexei Starovoitov
On Wed, Dec 09, 2015 at 10:41:38AM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Dec 09, 2015 at 11:10:48AM +0900, Masami Hiramatsu escreveu: > > Hi Arnaldo, > > > > Here is a series of patches for perf refcnt debugger and > > some fixes. > > > > In this series I've replaced all atomic

[PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-08 Thread Masami Hiramatsu
Hi Arnaldo, Here is a series of patches for perf refcnt debugger and some fixes. In this series I've replaced all atomic reference counters with the refcnt interface, including dso, map, map_groups, thread, cpu_map, comm_str, cgroup_sel, thread_map, and perf_mmap. refcnt debugger (or refcnt

[PATCH perf/core 00/22] perf refcnt debugger API and fixes

2015-12-08 Thread Masami Hiramatsu
Hi Arnaldo, Here is a series of patches for perf refcnt debugger and some fixes. In this series I've replaced all atomic reference counters with the refcnt interface, including dso, map, map_groups, thread, cpu_map, comm_str, cgroup_sel, thread_map, and perf_mmap. refcnt debugger (or refcnt