Re: [PATCH tip/core/rcu 20/21] checkpatch: Add warnings for {smp_,}read_barrier_depends()

2017-12-04 Thread Joe Perches
On Mon, 2017-12-04 at 11:06 -0800, Paul E. McKenney wrote: > On Fri, Dec 01, 2017 at 08:45:13PM -0800, Joe Perches wrote: > > On Fri, 2017-12-01 at 13:44 -0800, Paul E. McKenney wrote: > > > If you really wanted to optimize, you could make the first (smp_|) > > become (?:smp_|) to avoid the unused

Re: [PATCH tip/core/rcu 20/21] checkpatch: Add warnings for {smp_,}read_barrier_depends()

2017-12-04 Thread Paul E. McKenney
On Fri, Dec 01, 2017 at 08:45:13PM -0800, Joe Perches wrote: > On Fri, 2017-12-01 at 13:44 -0800, Paul E. McKenney wrote: [ . . . ] > > Good points! Like this? > [] > > commit ff155ce179aab891dbe2ca80f82a453383fd165a > > Author: Paul E. McKenney > > Date: Mon Nov 27 09:37:35 2017 -0800 > > >

Re: [PATCH tip/core/rcu 20/21] checkpatch: Add warnings for {smp_,}read_barrier_depends()

2017-12-01 Thread Joe Perches
On Fri, 2017-12-01 at 13:44 -0800, Paul E. McKenney wrote: > On Fri, Dec 01, 2017 at 12:14:17PM -0800, Joe Perches wrote: > > On Fri, 2017-12-01 at 11:51 -0800, Paul E. McKenney wrote: > > > Now that both smp_read_barrier_depends() and read_barrier_depends() > > > are being de-emphasized, warn if a

Re: [PATCH tip/core/rcu 20/21] checkpatch: Add warnings for {smp_,}read_barrier_depends()

2017-12-01 Thread Paul E. McKenney
On Fri, Dec 01, 2017 at 12:14:17PM -0800, Joe Perches wrote: > On Fri, 2017-12-01 at 11:51 -0800, Paul E. McKenney wrote: > > Now that both smp_read_barrier_depends() and read_barrier_depends() > > are being de-emphasized, warn if any are added. > > This would also warn on existing files when run

Re: [PATCH tip/core/rcu 20/21] checkpatch: Add warnings for {smp_,}read_barrier_depends()

2017-12-01 Thread Joe Perches
On Fri, 2017-12-01 at 11:51 -0800, Paul E. McKenney wrote: > Now that both smp_read_barrier_depends() and read_barrier_depends() > are being de-emphasized, warn if any are added. This would also warn on existing files when run with ./scripts/checkpatch.pl -f Do you want it to check new patches o

[PATCH tip/core/rcu 20/21] checkpatch: Add warnings for {smp_,}read_barrier_depends()

2017-12-01 Thread Paul E. McKenney
Now that both smp_read_barrier_depends() and read_barrier_depends() are being de-emphasized, warn if any are added. Signed-off-by: Paul E. McKenney Cc: Andy Whitcroft Cc: Joe Perches --- scripts/checkpatch.pl | 6 ++ 1 file changed, 6 insertions(+) diff --git a/scripts/checkpatch.pl b/scr