Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common() unsigned

2017-03-24 Thread Grant Grundler
On Thu, Mar 23, 2017 at 11:54 PM, Greg Kroah-Hartman wrote: > On Thu, Mar 23, 2017 at 02:47:39PM -0700, Grant Grundler wrote: >> On Tue, Mar 14, 2017 at 12:56 AM, Clemens Ladisch wrote: >> > Matthias Kaehlcke wrote: >> >> The value passed by the two callers of the function is unsigned anyway. >>

Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common() unsigned

2017-03-23 Thread Greg Kroah-Hartman
On Thu, Mar 23, 2017 at 02:47:39PM -0700, Grant Grundler wrote: > On Tue, Mar 14, 2017 at 12:56 AM, Clemens Ladisch wrote: > > Matthias Kaehlcke wrote: > >> The value passed by the two callers of the function is unsigned anyway. > > > > Indeed; and those are just simple wrappers. > > > >> Making t

Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common() unsigned

2017-03-23 Thread Grant Grundler
On Tue, Mar 14, 2017 at 12:56 AM, Clemens Ladisch wrote: > Matthias Kaehlcke wrote: >> The value passed by the two callers of the function is unsigned anyway. > > Indeed; and those are just simple wrappers. > >> Making the parameter unsigned fixes the following warning when building >> with clang:

Re: [PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common() unsigned

2017-03-14 Thread Clemens Ladisch
Matthias Kaehlcke wrote: > The value passed by the two callers of the function is unsigned anyway. Indeed; and those are just simple wrappers. > Making the parameter unsigned fixes the following warning when building > with clang: > > drivers/char/hpet.c:588:7: error: overflow converting case val

[PATCH v1] hpet: Make cmd parameter of hpet_ioctl_common() unsigned

2017-03-13 Thread Matthias Kaehlcke
The value passed by the two callers of the function is unsigned anyway. Making the parameter unsigned fixes the following warning when building with clang: drivers/char/hpet.c:588:7: error: overflow converting case value to switch condition type (2149083139 to 18446744071563667459) [-Werror,-Wsw