Re: [PATCH v1] mfd: intel-lpss: Move linux/pm.h to the local header

2019-02-12 Thread Lee Jones
On Thu, 24 Jan 2019, Andy Shevchenko wrote: > We now using a common macro for PM operations in Intel LPSS driver, > and, since that macro relies on the definition and macro from linux/pm.h > header file, it's logical to include it directly in intel-lpss.h. > Otherwise it's a bit fragile and

Re: [PATCH v1] mfd: intel-lpss: Move linux/pm.h to the local header

2019-02-12 Thread Lee Jones
On Fri, 08 Feb 2019, Andy Shevchenko wrote: > On Fri, Feb 01, 2019 at 03:08:17PM +, Lee Jones wrote: > > On Fri, 01 Feb 2019, Andy Shevchenko wrote: > > > On Fri, Feb 1, 2019 at 11:50 AM Lee Jones wrote: > > > > On Thu, 24 Jan 2019, Andy Shevchenko wrote: > > > > > > > > > We now using a

Re: [PATCH v1] mfd: intel-lpss: Move linux/pm.h to the local header

2019-02-08 Thread Andy Shevchenko
On Fri, Feb 01, 2019 at 03:08:17PM +, Lee Jones wrote: > On Fri, 01 Feb 2019, Andy Shevchenko wrote: > > On Fri, Feb 1, 2019 at 11:50 AM Lee Jones wrote: > > > On Thu, 24 Jan 2019, Andy Shevchenko wrote: > > > > > > > We now using a common macro for PM operations in Intel LPSS driver, > > > >

Re: [PATCH v1] mfd: intel-lpss: Move linux/pm.h to the local header

2019-02-01 Thread Lee Jones
On Fri, 01 Feb 2019, Andy Shevchenko wrote: > On Fri, Feb 1, 2019 at 11:50 AM Lee Jones wrote: > > > > On Thu, 24 Jan 2019, Andy Shevchenko wrote: > > > > > We now using a common macro for PM operations in Intel LPSS driver, > > > and, since that macro relies on the definition and macro from

Re: [PATCH v1] mfd: intel-lpss: Move linux/pm.h to the local header

2019-02-01 Thread Andy Shevchenko
On Fri, Feb 1, 2019 at 11:50 AM Lee Jones wrote: > > On Thu, 24 Jan 2019, Andy Shevchenko wrote: > > > We now using a common macro for PM operations in Intel LPSS driver, > > and, since that macro relies on the definition and macro from linux/pm.h > > header file, it's logical to include it

Re: [PATCH v1] mfd: intel-lpss: Move linux/pm.h to the local header

2019-02-01 Thread Lee Jones
On Thu, 24 Jan 2019, Andy Shevchenko wrote: > We now using a common macro for PM operations in Intel LPSS driver, > and, since that macro relies on the definition and macro from linux/pm.h > header file, it's logical to include it directly in intel-lpss.h. > Otherwise it's a bit fragile and

Re: [PATCH v1] mfd: intel-lpss: Move linux/pm.h to the local header

2019-01-29 Thread Mika Westerberg
On Thu, Jan 24, 2019 at 08:03:28PM +0200, Andy Shevchenko wrote: > We now using a common macro for PM operations in Intel LPSS driver, > and, since that macro relies on the definition and macro from linux/pm.h > header file, it's logical to include it directly in intel-lpss.h. > Otherwise it's a

[PATCH v1] mfd: intel-lpss: Move linux/pm.h to the local header

2019-01-24 Thread Andy Shevchenko
We now using a common macro for PM operations in Intel LPSS driver, and, since that macro relies on the definition and macro from linux/pm.h header file, it's logical to include it directly in intel-lpss.h. Otherwise it's a bit fragile and requires a proper ordering of header inclusion in C files.