Re: [PATCH v1 01/12] gna: add driver module

2021-03-09 Thread Maciej Kwapulinski
Greg Kroah-Hartman writes: > On Fri, Feb 26, 2021 at 01:59:14PM +0100, Maciej Kwapulinski wrote: >> >> Greg Kroah-Hartman writes: >> >> > On Tue, Feb 16, 2021 at 05:05:14PM +0100, Maciej Kwapulinski wrote: >> >> >> --- /dev/null >> >> +++ b/drivers/misc/gna/gna_driver.h >> >> @@ -0,0

Re: [PATCH v1 01/12] gna: add driver module

2021-03-01 Thread Maciej Kwapulinski
Greg Kroah-Hartman writes: > On Mon, Mar 01, 2021 at 11:39:23AM +0100, Maciej Kwapulinski wrote: >> >> Maciej Kwapulinski writes: >> >> > Greg Kroah-Hartman writes: >> > >> >> On Mon, Mar 01, 2021 at 11:18:59AM +0100, Maciej Kwapulinski wrote: >> >>> >> >>> Andy Shevchenko writes: >> >>>

Re: [PATCH v1 01/12] gna: add driver module

2021-03-01 Thread Greg Kroah-Hartman
On Mon, Mar 01, 2021 at 11:39:23AM +0100, Maciej Kwapulinski wrote: > > Maciej Kwapulinski writes: > > > Greg Kroah-Hartman writes: > > > >> On Mon, Mar 01, 2021 at 11:18:59AM +0100, Maciej Kwapulinski wrote: > >>> > >>> Andy Shevchenko writes: > >>> > >>> > On Tue, Feb 16, 2021 at 6:11 PM

Re: [PATCH v1 01/12] gna: add driver module

2021-03-01 Thread Maciej Kwapulinski
Maciej Kwapulinski writes: > Greg Kroah-Hartman writes: > >> On Mon, Mar 01, 2021 at 11:18:59AM +0100, Maciej Kwapulinski wrote: >>> >>> Andy Shevchenko writes: >>> >>> > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski >>> > wrote: >>> >> >>> >>> >> +static int __init

Re: [PATCH v1 01/12] gna: add driver module

2021-03-01 Thread Maciej Kwapulinski
Greg Kroah-Hartman writes: > On Mon, Mar 01, 2021 at 11:18:59AM +0100, Maciej Kwapulinski wrote: >> >> Andy Shevchenko writes: >> >> > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski >> > wrote: >> >> >> >> >> +static int __init gna_drv_init(void) >> >> +{ >> >> + int ret; >>

Re: [PATCH v1 01/12] gna: add driver module

2021-03-01 Thread Greg Kroah-Hartman
On Mon, Mar 01, 2021 at 11:18:59AM +0100, Maciej Kwapulinski wrote: > > Andy Shevchenko writes: > > > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski > > wrote: > >> > > >> +static int __init gna_drv_init(void) > >> +{ > >> + int ret; > >> + > >> +

Re: [PATCH v1 01/12] gna: add driver module

2021-03-01 Thread Maciej Kwapulinski
Andy Shevchenko writes: > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski > wrote: >> >> +static int __init gna_drv_init(void) >> +{ >> + int ret; >> + >> + mutex_init(_drv_priv.lock); >> + >> + gna_class = class_create(THIS_MODULE, "gna"); >> + if

Re: [PATCH v1 01/12] gna: add driver module

2021-02-26 Thread Greg Kroah-Hartman
On Fri, Feb 26, 2021 at 07:29:39PM +0100, Maciej Kwapulinski wrote: > > Andy Shevchenko writes: > > > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski > > wrote: > >> > > >> +#define GNA_DRV_VER"1.2.0" > > > > Nowadays the version is the Git SHA sum. > > > > right, "version" is

Re: [PATCH v1 01/12] gna: add driver module

2021-02-26 Thread Jianxun Zhang
> On Feb 26, 2021, at 10:29 AM, Maciej Kwapulinski > wrote: > > > Andy Shevchenko writes: > >> On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski >> wrote: >>> > >>> +#define GNA_DRV_VER"1.2.0" >> >> Nowadays the version is the Git SHA sum. >> > > right, "version" is present

Re: [PATCH v1 01/12] gna: add driver module

2021-02-26 Thread Maciej Kwapulinski
Andy Shevchenko writes: > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski > wrote: >> >> +#define GNA_DRV_VER"1.2.0" > > Nowadays the version is the Git SHA sum. > right, "version" is present in about 7% of all modules do You mean version should be skipped over (automatically

Re: [PATCH v1 01/12] gna: add driver module

2021-02-26 Thread Greg Kroah-Hartman
On Fri, Feb 26, 2021 at 01:59:14PM +0100, Maciej Kwapulinski wrote: > > Greg Kroah-Hartman writes: > > > On Tue, Feb 16, 2021 at 05:05:14PM +0100, Maciej Kwapulinski wrote: > > >> --- /dev/null > >> +++ b/drivers/misc/gna/gna_driver.h > >> @@ -0,0 +1,41 @@ > >> +/* SPDX-License-Identifier:

Re: [PATCH v1 01/12] gna: add driver module

2021-02-26 Thread Maciej Kwapulinski
Greg Kroah-Hartman writes: > On Tue, Feb 16, 2021 at 05:05:14PM +0100, Maciej Kwapulinski wrote: >> --- /dev/null >> +++ b/drivers/misc/gna/gna_driver.h >> @@ -0,0 +1,41 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* Copyright(c) 2017-2021 Intel Corporation */ >> + >> +#ifndef

Re: [PATCH v1 01/12] gna: add driver module

2021-02-19 Thread Andy Shevchenko
On Fri, Feb 19, 2021 at 3:21 PM Maciej Kwapulinski wrote: > Andy Shevchenko writes: > > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski > > wrote: > >> > > >> +err_clear_master: > >> + pci_clear_master(pcidev); > >> +err_release_regions: > >> + pci_release_regions(pcidev); >

Re: [PATCH v1 01/12] gna: add driver module

2021-02-19 Thread Maciej Kwapulinski
Andy Shevchenko writes: > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski > wrote: >> >> +err_clear_master: >> + pci_clear_master(pcidev); >> +err_release_regions: >> + pci_release_regions(pcidev); >> +end: >> + dev_err(>dev, "gna probe failed with %d\n", ret); >> +

Re: [PATCH v1 01/12] gna: add driver module

2021-02-16 Thread Maciej Kwapulinski
Greg Kroah-Hartman writes: > On Tue, Feb 16, 2021 at 05:05:14PM +0100, Maciej Kwapulinski wrote: >> --- /dev/null >> +++ b/drivers/misc/gna/gna_driver.c >> @@ -0,0 +1,65 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +// Copyright(c) 2017-2021 Intel Corporation >> + >> +#define pr_fmt(fmt)

Re: [PATCH v1 01/12] gna: add driver module

2021-02-16 Thread Randy Dunlap
Hi-- On 2/16/21 8:05 AM, Maciej Kwapulinski wrote: > diff --git a/Documentation/misc-devices/gna.rst > b/Documentation/misc-devices/gna.rst > new file mode 100644 > index ..ed3d5a89271d > --- /dev/null > +++ b/Documentation/misc-devices/gna.rst > @@ -0,0 +1,48 @@ > +..

Re: [PATCH v1 01/12] gna: add driver module

2021-02-16 Thread Greg Kroah-Hartman
On Tue, Feb 16, 2021 at 05:05:14PM +0100, Maciej Kwapulinski wrote: > --- /dev/null > +++ b/drivers/misc/gna/gna_driver.c > @@ -0,0 +1,65 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +// Copyright(c) 2017-2021 Intel Corporation > + > +#define pr_fmt(fmt) KBUILD_MODNAME " " fmt You are a

Re: [PATCH v1 01/12] gna: add driver module

2021-02-16 Thread Jianxun Zhang
> On Feb 16, 2021, at 8:54 AM, Andy Shevchenko > wrote: > >> +config INTEL_GNA >> + tristate "Intel(R) Gaussian & Neural Accelerator (Intel(R) GNA)" > > Intel (R) Intel (R) RRR! This is (from my interpretation) of requirements and guidance specific on how to address this HW IP from

Re: [PATCH v1 01/12] gna: add driver module

2021-02-16 Thread Andy Shevchenko
On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski wrote: > > From: Tomasz Jankowski > > Add a new PCI driver for Intel(R) Gaussian & Neural Accelerator > with basic support like module loading and unloading. The full > function of the driver will be added by further changes. ... > +config

[PATCH v1 01/12] gna: add driver module

2021-02-16 Thread Maciej Kwapulinski
From: Tomasz Jankowski Add a new PCI driver for Intel(R) Gaussian & Neural Accelerator with basic support like module loading and unloading. The full function of the driver will be added by further changes. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun