Re: [PATCH v1 05/15] ASoC: fsl_ssi: Clean up helper functions of trigger()

2018-01-04 Thread Nicolin Chen
On Mon, Jan 01, 2018 at 10:59:30PM +0100, Maciej S. Szmigiero wrote: > > +static void fsl_ssi_config_enable(struct fsl_ssi *ssi, bool tx) > > + srcr = vals[tx].srcr; > > + stcr = vals[tx].stcr; > > + sier = vals[tx].sier; > > Implicit assumption here that RX == 0,

Re: [PATCH v1 05/15] ASoC: fsl_ssi: Clean up helper functions of trigger()

2018-01-04 Thread Nicolin Chen
On Mon, Jan 01, 2018 at 10:59:30PM +0100, Maciej S. Szmigiero wrote: > > +static void fsl_ssi_config_enable(struct fsl_ssi *ssi, bool tx) > > + srcr = vals[tx].srcr; > > + stcr = vals[tx].stcr; > > + sier = vals[tx].sier; > > Implicit assumption here that RX == 0,

Re: [PATCH v1 05/15] ASoC: fsl_ssi: Clean up helper functions of trigger()

2018-01-01 Thread Maciej S. Szmigiero
On 19.12.2017 18:00, Nicolin Chen wrote: > The trigger() calls fsl_ssi_tx_config() and fsl_ssi_rx_config(), > and both of them jump to fsl_ssi_config(). And fsl_ssi_config() > later calls another fsl_ssi_rxtx_config(). > > However, the whole routine, especially fsl_ssi_config() function, > is too

Re: [PATCH v1 05/15] ASoC: fsl_ssi: Clean up helper functions of trigger()

2018-01-01 Thread Maciej S. Szmigiero
On 19.12.2017 18:00, Nicolin Chen wrote: > The trigger() calls fsl_ssi_tx_config() and fsl_ssi_rx_config(), > and both of them jump to fsl_ssi_config(). And fsl_ssi_config() > later calls another fsl_ssi_rxtx_config(). > > However, the whole routine, especially fsl_ssi_config() function, > is too

[PATCH v1 05/15] ASoC: fsl_ssi: Clean up helper functions of trigger()

2017-12-19 Thread Nicolin Chen
The trigger() calls fsl_ssi_tx_config() and fsl_ssi_rx_config(), and both of them jump to fsl_ssi_config(). And fsl_ssi_config() later calls another fsl_ssi_rxtx_config(). However, the whole routine, especially fsl_ssi_config() function, is too complicated because of the folowing reasons: 1) It

[PATCH v1 05/15] ASoC: fsl_ssi: Clean up helper functions of trigger()

2017-12-19 Thread Nicolin Chen
The trigger() calls fsl_ssi_tx_config() and fsl_ssi_rx_config(), and both of them jump to fsl_ssi_config(). And fsl_ssi_config() later calls another fsl_ssi_rxtx_config(). However, the whole routine, especially fsl_ssi_config() function, is too complicated because of the folowing reasons: 1) It