Re: [PATCH v1 05/20] signal: flatten do_send_sig_info()

2018-05-30 Thread Eric W. Biederman
Christian Brauner writes: 2> On Tue, May 29, 2018 at 07:28:27AM -0500, Eric W. Biederman wrote: >> Christian Brauner writes: >> >> > Let's return early when lock_task_sighand() fails and move send_signal() >> > and unlock_task_sighand() out of the if block. >> >> Introducing multiple exits int

Re: [PATCH v1 05/20] signal: flatten do_send_sig_info()

2018-05-29 Thread Christian Brauner
On Tue, May 29, 2018 at 07:28:27AM -0500, Eric W. Biederman wrote: > Christian Brauner writes: > > > Let's return early when lock_task_sighand() fails and move send_signal() > > and unlock_task_sighand() out of the if block. > > Introducing multiple exits into a function. Ick. > You do know tha

Re: [PATCH v1 05/20] signal: flatten do_send_sig_info()

2018-05-29 Thread Eric W. Biederman
Christian Brauner writes: > Let's return early when lock_task_sighand() fails and move send_signal() > and unlock_task_sighand() out of the if block. Introducing multiple exits into a function. Ick. You do know that is what Dijkstra was arguing against in his paper "Goto Considered Harmful" Th

[PATCH v1 05/20] signal: flatten do_send_sig_info()

2018-05-28 Thread Christian Brauner
Let's return early when lock_task_sighand() fails and move send_signal() and unlock_task_sighand() out of the if block. Signed-off-by: Christian Brauner --- v0->v1: * patch unchanged --- kernel/signal.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/signal.