Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-12 Thread Jonathan Cameron
On Tue, 9 Mar 2021 12:40:46 +0100 Oleksij Rempel wrote: > Hi Jonathan, > > On Sat, Mar 06, 2021 at 02:59:59PM +, Jonathan Cameron wrote: > > On Sat, 6 Mar 2021 14:28:52 +0100 > > Oleksij Rempel wrote: > > > > > On Fri, Mar 05, 2021 at 07:02:39PM +, Jonathan Cameron wrote: > > > > O

Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-09 Thread Andy Shevchenko
On Fri, Mar 5, 2021 at 3:40 PM Oleksij Rempel wrote: I have heard it will be a new version, so below a lot of nit-picks. > Basically the TI TSC2046 touchscreen controller is 8 channel ADC optimized for > the touchscreen use case. By implementing it as IIO ADC device, we can an IIO > make use o

Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-09 Thread Andy Shevchenko
On Tue, Mar 9, 2021 at 2:18 PM Oleksij Rempel wrote: > > On Tue, Mar 09, 2021 at 01:46:55PM +0200, Andy Shevchenko wrote: > > On Tue, Mar 9, 2021 at 1:42 PM Oleksij Rempel > > wrote: > > > On Tue, Mar 09, 2021 at 01:05:27PM +0200, Andy Shevchenko wrote: > > > > On Fri, Mar 5, 2021 at 9:05 PM Jon

Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-09 Thread Oleksij Rempel
On Tue, Mar 09, 2021 at 01:46:55PM +0200, Andy Shevchenko wrote: > On Tue, Mar 9, 2021 at 1:42 PM Oleksij Rempel wrote: > > On Tue, Mar 09, 2021 at 01:05:27PM +0200, Andy Shevchenko wrote: > > > On Fri, Mar 5, 2021 at 9:05 PM Jonathan Cameron > > > wrote: > > > > > > > > On Fri, 5 Mar 2021 14:38:

Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-09 Thread Andy Shevchenko
On Tue, Mar 9, 2021 at 1:42 PM Oleksij Rempel wrote: > On Tue, Mar 09, 2021 at 01:05:27PM +0200, Andy Shevchenko wrote: > > On Fri, Mar 5, 2021 at 9:05 PM Jonathan Cameron > > wrote: > > > > > > On Fri, 5 Mar 2021 14:38:13 +0100 > > > Oleksij Rempel wrote: > > > > > > > Basically the TI TSC2046

Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-09 Thread Oleksij Rempel
On Tue, Mar 09, 2021 at 01:05:27PM +0200, Andy Shevchenko wrote: > On Fri, Mar 5, 2021 at 9:05 PM Jonathan Cameron > wrote: > > > > On Fri, 5 Mar 2021 14:38:13 +0100 > > Oleksij Rempel wrote: > > > > > Basically the TI TSC2046 touchscreen controller is 8 channel ADC > > > optimized for > > > the

Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-09 Thread Oleksij Rempel
Hi Jonathan, On Sat, Mar 06, 2021 at 02:59:59PM +, Jonathan Cameron wrote: > On Sat, 6 Mar 2021 14:28:52 +0100 > Oleksij Rempel wrote: > > > On Fri, Mar 05, 2021 at 07:02:39PM +, Jonathan Cameron wrote: > > > On Fri, 5 Mar 2021 14:38:13 +0100 > > > Oleksij Rempel wrote: > > > > > > >

Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-09 Thread Oleksij Rempel
On Sun, Mar 07, 2021 at 03:05:31PM -0800, Dmitry Torokhov wrote: > Hi Oleksij, > > On Fri, Mar 05, 2021 at 02:38:13PM +0100, Oleksij Rempel wrote: > > + > > + /* TODO: remove IRQ_NOAUTOEN after needed patches are mainline */ > > + irq_set_status_flags(spi->irq, IRQ_NOAUTOEN); > > + ret = dev

Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-09 Thread Andy Shevchenko
On Fri, Mar 5, 2021 at 9:05 PM Jonathan Cameron wrote: > > On Fri, 5 Mar 2021 14:38:13 +0100 > Oleksij Rempel wrote: > > > Basically the TI TSC2046 touchscreen controller is 8 channel ADC optimized > > for > > the touchscreen use case. By implementing it as IIO ADC device, we can > > make use of

Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-07 Thread Dmitry Torokhov
Hi Oleksij, On Fri, Mar 05, 2021 at 02:38:13PM +0100, Oleksij Rempel wrote: > + > + /* TODO: remove IRQ_NOAUTOEN after needed patches are mainline */ > + irq_set_status_flags(spi->irq, IRQ_NOAUTOEN); > + ret = devm_request_threaded_irq(dev, spi->irq, > +

Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-06 Thread Jonathan Cameron
On Sat, 6 Mar 2021 14:28:52 +0100 Oleksij Rempel wrote: > On Fri, Mar 05, 2021 at 07:02:39PM +, Jonathan Cameron wrote: > > On Fri, 5 Mar 2021 14:38:13 +0100 > > Oleksij Rempel wrote: > > > > > Basically the TI TSC2046 touchscreen controller is 8 channel ADC > > > optimized for > > > the

Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-06 Thread Oleksij Rempel
On Fri, Mar 05, 2021 at 07:02:39PM +, Jonathan Cameron wrote: > On Fri, 5 Mar 2021 14:38:13 +0100 > Oleksij Rempel wrote: > > > Basically the TI TSC2046 touchscreen controller is 8 channel ADC optimized > > for > > the touchscreen use case. By implementing it as IIO ADC device, we can > > ma

Re: [PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-05 Thread Jonathan Cameron
On Fri, 5 Mar 2021 14:38:13 +0100 Oleksij Rempel wrote: > Basically the TI TSC2046 touchscreen controller is 8 channel ADC optimized for > the touchscreen use case. By implementing it as IIO ADC device, we can > make use of resistive-adc-touch and iio-hwmon drivers. > > So far, this driver was t

[PATCH v1 2/2] iio: adc: add ADC driver for the TI TSC2046 controller

2021-03-05 Thread Oleksij Rempel
Basically the TI TSC2046 touchscreen controller is 8 channel ADC optimized for the touchscreen use case. By implementing it as IIO ADC device, we can make use of resistive-adc-touch and iio-hwmon drivers. So far, this driver was tested with custom version of resistive-adc-touch driver, since it n