Re: [PATCH v1 2/2] rockchip: power-domain: support qos save and restore

2016-04-05 Thread Heiko Stuebner
Hi Elaine, Am Dienstag, 5. April 2016, 09:57:20 schrieb Elaine Zhang: > Thanks for your replay. > For your questions, I also have the same concerns. > > On 04/02/2016 12:19 AM, Heiko Stuebner wrote: > > Am Freitag, 1. April 2016, 10:33:45 schrieb Elaine Zhang: > >> I agree with most of your modif

Re: [PATCH v1 2/2] rockchip: power-domain: support qos save and restore

2016-04-04 Thread Elaine Zhang
hi, Heiko: Thanks for your replay. For your questions, I also have the same concerns. On 04/02/2016 12:19 AM, Heiko Stuebner wrote: Hi Elaine, Am Freitag, 1. April 2016, 10:33:45 schrieb Elaine Zhang: I agree with most of your modifications. Except, the u32 *qos_save_regs below you're right

Re: [PATCH v1 2/2] rockchip: power-domain: support qos save and restore

2016-04-01 Thread Heiko Stuebner
Hi Elaine, Am Freitag, 1. April 2016, 10:33:45 schrieb Elaine Zhang: > I agree with most of your modifications. > Except, the u32 *qos_save_regs below you're right. I didn't take that into account when my open-coding my idea. A bit more below: > On 04/01/2016 12:31 AM, Heiko Stuebner wrote: > >

Re: [PATCH v1 2/2] rockchip: power-domain: support qos save and restore

2016-03-31 Thread Elaine Zhang
hi, Heiko I agree with most of your modifications. Except, the u32 *qos_save_regs below On 04/01/2016 12:31 AM, Heiko Stuebner wrote: Hi Elaine, Am Freitag, 18. März 2016, 15:17:24 schrieb Elaine Zhang: support qos save and restore when power domain on/off. Signed-off-by: Elaine Zhang ov

Re: [PATCH v1 2/2] rockchip: power-domain: support qos save and restore

2016-03-31 Thread Heiko Stuebner
Hi Elaine, Am Freitag, 18. März 2016, 15:17:24 schrieb Elaine Zhang: > support qos save and restore when power domain on/off. > > Signed-off-by: Elaine Zhang overall looks nice already ... some implementation-specific comments below. > --- > drivers/soc/rockchip/pm_domains.c | 87 > ++

[PATCH v1 2/2] rockchip: power-domain: support qos save and restore

2016-03-19 Thread Elaine Zhang
support qos save and restore when power domain on/off. Signed-off-by: Elaine Zhang --- drivers/soc/rockchip/pm_domains.c | 87 +-- 1 file changed, 84 insertions(+), 3 deletions(-) diff --git a/drivers/soc/rockchip/pm_domains.c b/drivers/soc/rockchip/pm_domai