Re: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM

2020-12-08 Thread Bean Huo
On Tue, 2020-12-08 at 08:35 +, Avri Altman wrote: > > didn't differenciate them. we take all of these as CDB. This is > > wrong. > > > > I want to make it clearer and make UPIU trace in line with the > > Spec. > > what's more, how do you filter OSF, TM parameters with current > > UPIU > > tra

Re: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM

2020-12-08 Thread Bean Huo
On Mon, 2020-12-07 at 10:34 -0500, Steven Rostedt wrote: > On Sun, 6 Dec 2020 17:42:26 +0100 > Bean Huo wrote: > > > From: Bean Huo > > > > Transaction Specific Fields (TSF) in the UPIU package could be CDB > > (SCSI/UFS Command Descriptor Block), OSF (Opcode Specific Field), > > and > > TM I/

RE: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM

2020-12-08 Thread Avri Altman
> > On Mon, 2020-12-07 at 07:57 +, Avri Altman wrote: > > > TP_printk( > > > - "%s: %s: HDR:%s, CDB:%s", > > > + "%s: %s: HDR:%s, %s:%s", > > > __get_str(str), __get_str(dev_name), > > > __print_hex(__entry->hdr, sizeof(__e

RE: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM

2020-12-08 Thread Avri Altman
> > On Mon, 7 Dec 2020 16:40:51 + > Avri Altman wrote: > > > > > > > On Mon, 7 Dec 2020 07:57:27 + > > > Avri Altman wrote: > > > > > > > > > > > > > TP_printk( > > > > > - "%s: %s: HDR:%s, CDB:%s", > > > > > + "%s: %s: HDR:%s, %s:%s", > > > > >

Re: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM

2020-12-07 Thread Steven Rostedt
On Mon, 7 Dec 2020 16:40:51 + Avri Altman wrote: > > > > On Mon, 7 Dec 2020 07:57:27 + > > Avri Altman wrote: > > > > > > > > > > TP_printk( > > > > - "%s: %s: HDR:%s, CDB:%s", > > > > + "%s: %s: HDR:%s, %s:%s", > > > > __get_str(st

RE: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM

2020-12-07 Thread Avri Altman
> > On Mon, 7 Dec 2020 07:57:27 + > Avri Altman wrote: > > > > > > > TP_printk( > > > - "%s: %s: HDR:%s, CDB:%s", > > > + "%s: %s: HDR:%s, %s:%s", > > > __get_str(str), __get_str(dev_name), > > > __print_hex(__entry->hdr, si

Re: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM

2020-12-07 Thread Steven Rostedt
On Mon, 7 Dec 2020 07:57:27 + Avri Altman wrote: > > > > TP_printk( > > - "%s: %s: HDR:%s, CDB:%s", > > + "%s: %s: HDR:%s, %s:%s", > > __get_str(str), __get_str(dev_name), > > __print_hex(__entry->hdr, sizeof(__entry->hdr)),

Re: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM

2020-12-07 Thread Steven Rostedt
On Sun, 6 Dec 2020 17:42:26 +0100 Bean Huo wrote: > From: Bean Huo > > Transaction Specific Fields (TSF) in the UPIU package could be CDB > (SCSI/UFS Command Descriptor Block), OSF (Opcode Specific Field), and > TM I/O parameter (Task Management Input/Output Parameter). But, currently, > we ta

Re: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM

2020-12-07 Thread Bean Huo
On Mon, 2020-12-07 at 07:57 +, Avri Altman wrote: > > TP_printk( > > - "%s: %s: HDR:%s, CDB:%s", > > + "%s: %s: HDR:%s, %s:%s", > > __get_str(str), __get_str(dev_name), > > __print_hex(__entry->hdr, sizeof(__entry->hdr)), >

RE: [PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM

2020-12-06 Thread Avri Altman
> > > From: Bean Huo > > Transaction Specific Fields (TSF) in the UPIU package could be CDB > (SCSI/UFS Command Descriptor Block), OSF (Opcode Specific Field), and > TM I/O parameter (Task Management Input/Output Parameter). But, > currently, > we take all of these as CDB in the UPIU trace. Th

[PATCH v1 3/3] scsi: ufs: Make UPIU trace easier differentiate among CDB, OSF, and TM

2020-12-06 Thread Bean Huo
From: Bean Huo Transaction Specific Fields (TSF) in the UPIU package could be CDB (SCSI/UFS Command Descriptor Block), OSF (Opcode Specific Field), and TM I/O parameter (Task Management Input/Output Parameter). But, currently, we take all of these as CDB in the UPIU trace. Thus makes user confus