Re: [PATCH v1.1] x86/mm/ASLR: Propagate ASLR status to kernel proper

2015-04-13 Thread Yinghai Lu
On Thu, Apr 2, 2015 at 4:50 AM, Borislav Petkov wrote: > On Thu, Apr 02, 2015 at 01:29:30PM +0200, Ingo Molnar wrote: >> So was this duplication dead code in essence? > > See e2b32e678513. > > Looks like it was parsing the cmdline option for a second time in the > kernel proper (vs first one which

Re: [PATCH v1.1] x86/mm/ASLR: Propagate ASLR status to kernel proper

2015-04-02 Thread Borislav Petkov
On Thu, Apr 02, 2015 at 01:29:30PM +0200, Ingo Molnar wrote: > So was this duplication dead code in essence? See e2b32e678513. Looks like it was parsing the cmdline option for a second time in the kernel proper (vs first one which we still parse in the compressed kernel). hpa said that we probab

Re: [PATCH v1.1] x86/mm/ASLR: Propagate ASLR status to kernel proper

2015-04-02 Thread Ingo Molnar
* Borislav Petkov wrote: > On Thu, Apr 02, 2015 at 01:07:13PM +0200, Ingo Molnar wrote: > > So doesn't a 'nokaslr' boot option still make sense, to be able to > > debug KASLR failures and such? > > That's still parsed in arch/x86/boot/compressed/aslr.c So was this duplication dead code in ess

Re: [PATCH v1.1] x86/mm/ASLR: Propagate ASLR status to kernel proper

2015-04-02 Thread Borislav Petkov
On Thu, Apr 02, 2015 at 01:07:13PM +0200, Ingo Molnar wrote: > So doesn't a 'nokaslr' boot option still make sense, to be able to > debug KASLR failures and such? That's still parsed in arch/x86/boot/compressed/aslr.c > > + if (kaslr_enabled()) > > + pr_emerg("Kernel Offset: 0x%lx fr

Re: [PATCH v1.1] x86/mm/ASLR: Propagate ASLR status to kernel proper

2015-04-02 Thread Ingo Molnar
* Borislav Petkov wrote: > --- a/arch/x86/kernel/module.c > +++ b/arch/x86/kernel/module.c > @@ -33,6 +33,7 @@ > > #include > #include > +#include > > #if 0 > #define DEBUGP(fmt, ...) \ > @@ -47,21 +48,13 @@ do {

[PATCH v1.1] x86/mm/ASLR: Propagate ASLR status to kernel proper

2015-04-01 Thread Borislav Petkov
From: Borislav Petkov Date: Wed, 1 Apr 2015 12:49:52 +0200 Subject: [PATCH v1.1] x86/mm/ASLR: Propagate ASLR status to kernel proper Commit e2b32e678513 ("x86, kaslr: randomize module base load address") made module base address randomization unconditional and didn't regard