atform-driver-
> x...@vger.kernel.org; l...@kernel.org; quasi...@google.com;
> pali.ro...@gmail.com; r...@rjwysocki.net; mj...@google.com;
> gno...@lxorguk.ukuu.org.uk
> Subject: Re: [PATCH v10 13/15] platform/x86: wmi: create userspace interface
> for
> drivers
>
> On Fri, Oct 20
On Fri, Oct 20, 2017 at 03:07:27PM +, mario.limoncie...@dell.com wrote:
> No drivers do this today, it's obviously not a good idea.
> I was just saying it's hypothetical.
If there is no one using the exported methods don't export them.
vger.kernel.org; l...@kernel.org;
> quasi...@google.com; pali.ro...@gmail.com; r...@rjwysocki.net;
> mj...@google.com; h...@lst.de; gno...@lxorguk.ukuu.org.uk
> Subject: Re: [PATCH v10 13/15] platform/x86: wmi: create userspace interface
> for
> drivers
>
> On Fri, Oct 20, 2017 at 01:54
o ;
> > LKML ; platform-driver-...@vger.kernel.org;
> > Andy
> > Lutomirski ; quasi...@google.com; pali.ro...@gmail.com;
> > r...@rjwysocki.net; mj...@google.com; h...@lst.de; Alan Cox
> >
> > Subject: Re: [PATCH v10 13/15] platform/x86: wmi: create userspace
&g
o ;
> > LKML ; platform-driver-...@vger.kernel.org;
> > Andy
> > Lutomirski ; quasi...@google.com; pali.ro...@gmail.com;
> > r...@rjwysocki.net; mj...@google.com; h...@lst.de; Alan Cox
> >
> > Subject: Re: [PATCH v10 13/15] platform/x86: wmi: create userspace
&g
.ro...@gmail.com;
> r...@rjwysocki.net; mj...@google.com; h...@lst.de; Alan Cox
>
> Subject: Re: [PATCH v10 13/15] platform/x86: wmi: create userspace interface
> for
> drivers
>
> On Thu, Oct 19, 2017 at 12:50:16PM -0500, Mario Limonciello wrote:
> > +#ifdef CONFIG_COMPAT
.ro...@gmail.com;
> r...@rjwysocki.net; mj...@google.com; h...@lst.de; Alan Cox
>
> Subject: Re: [PATCH v10 13/15] platform/x86: wmi: create userspace interface
> for
> drivers
>
> On Thu, Oct 19, 2017 at 12:50:16PM -0500, Mario Limonciello wrote:
> > +static ssize_t wmi_
.ro...@gmail.com;
> r...@rjwysocki.net; mj...@google.com; h...@lst.de; Alan Cox
>
> Subject: Re: [PATCH v10 13/15] platform/x86: wmi: create userspace interface
> for
> drivers
>
> On Thu, Oct 19, 2017 at 12:50:16PM -0500, Mario Limonciello wrote:
> > + wblock = conta
On Thu, Oct 19, 2017 at 12:50:16PM -0500, Mario Limonciello wrote:
> +#ifdef CONFIG_COMPAT
> + .compat_ioctl = wmi_ioctl,
Why do you still need a compat ioctl?
On Thu, Oct 19, 2017 at 12:50:16PM -0500, Mario Limonciello wrote:
> +static ssize_t wmi_char_read(struct file *filp, char __user *buffer,
> + size_t length, loff_t *offset)
> +{
> + struct wmi_block *wblock = filp->private_data;
> + size_t count;
> +
> + if (*offset != 0)
> +
On Thu, Oct 19, 2017 at 12:50:16PM -0500, Mario Limonciello wrote:
> + wblock = container_of(wdev, struct wmi_block, dev);
> + if (!wblock)
> + return -ENODEV;
How can container_of() ever return NULL? If so, you have a very odd
memory layout...
> + list_for_each_entry_saf
For WMI operations that are only Set or Query readable and writable sysfs
attributes created by WMI vendor drivers or the bus driver makes sense.
For other WMI operations that are run on Method, there needs to be a
way to guarantee to userspace that the results from the method call
belong to the d
12 matches
Mail list logo
