Re: [PATCH v10 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller

2018-09-06 Thread Baolin Wang
Hi Pavel, On 7 September 2018 at 05:16, Pavel Machek wrote: > Hi! > >> diff --git a/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx >> b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx >> new file mode 100644 >> index 000..d8056d5 >> --- /dev/null >> +++

Re: [PATCH v10 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller

2018-09-06 Thread Baolin Wang
Hi Pavel, On 7 September 2018 at 05:16, Pavel Machek wrote: > Hi! > >> diff --git a/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx >> b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx >> new file mode 100644 >> index 000..d8056d5 >> --- /dev/null >> +++

Re: [PATCH v10 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller

2018-09-06 Thread Baolin Wang
Hi Jacek, On 7 September 2018 at 04:16, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for the patch. I really appreciate your effort. > > I see one more thing I forgot to mention in the previous > review. Please take a look at my comment to pattern_set(). > > On 09/06/2018 04:37 AM, Baolin

Re: [PATCH v10 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller

2018-09-06 Thread Baolin Wang
Hi Jacek, On 7 September 2018 at 04:16, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for the patch. I really appreciate your effort. > > I see one more thing I forgot to mention in the previous > review. Please take a look at my comment to pattern_set(). > > On 09/06/2018 04:37 AM, Baolin

Re: [PATCH v10 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller

2018-09-06 Thread Pavel Machek
Hi! > diff --git a/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx > b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx > new file mode 100644 > index 000..d8056d5 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx > @@ -0,0 +1,22 @@ > +What:

Re: [PATCH v10 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller

2018-09-06 Thread Pavel Machek
Hi! > diff --git a/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx > b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx > new file mode 100644 > index 000..d8056d5 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx > @@ -0,0 +1,22 @@ > +What:

Re: [PATCH v10 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller

2018-09-06 Thread Jacek Anaszewski
Hi Baolin, Thank you for the patch. I really appreciate your effort. I see one more thing I forgot to mention in the previous review. Please take a look at my comment to pattern_set(). On 09/06/2018 04:37 AM, Baolin Wang wrote: > This patch implements the 'pattern_set'and 'pattern_clear' >

Re: [PATCH v10 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller

2018-09-06 Thread Jacek Anaszewski
Hi Baolin, Thank you for the patch. I really appreciate your effort. I see one more thing I forgot to mention in the previous review. Please take a look at my comment to pattern_set(). On 09/06/2018 04:37 AM, Baolin Wang wrote: > This patch implements the 'pattern_set'and 'pattern_clear' >

[PATCH v10 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller

2018-09-05 Thread Baolin Wang
This patch implements the 'pattern_set'and 'pattern_clear' interfaces to support SC27XX LED breathing mode. Signed-off-by: Baolin Wang --- Changes from v9: - Optimize the ABI documentation file. - Update the brightness value in hardware pattern mode. Changes from v8: - Optimize the ABI

[PATCH v10 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller

2018-09-05 Thread Baolin Wang
This patch implements the 'pattern_set'and 'pattern_clear' interfaces to support SC27XX LED breathing mode. Signed-off-by: Baolin Wang --- Changes from v9: - Optimize the ABI documentation file. - Update the brightness value in hardware pattern mode. Changes from v8: - Optimize the ABI