Hi Pavel,
On 7 September 2018 at 05:16, Pavel Machek wrote:
> Hi!
>
>> diff --git a/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx
>> b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx
>> new file mode 100644
>> index 000..d8056d5
>> --- /dev/null
>> +++
Hi Pavel,
On 7 September 2018 at 05:16, Pavel Machek wrote:
> Hi!
>
>> diff --git a/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx
>> b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx
>> new file mode 100644
>> index 000..d8056d5
>> --- /dev/null
>> +++
Hi Jacek,
On 7 September 2018 at 04:16, Jacek Anaszewski
wrote:
> Hi Baolin,
>
> Thank you for the patch. I really appreciate your effort.
>
> I see one more thing I forgot to mention in the previous
> review. Please take a look at my comment to pattern_set().
>
> On 09/06/2018 04:37 AM, Baolin
Hi Jacek,
On 7 September 2018 at 04:16, Jacek Anaszewski
wrote:
> Hi Baolin,
>
> Thank you for the patch. I really appreciate your effort.
>
> I see one more thing I forgot to mention in the previous
> review. Please take a look at my comment to pattern_set().
>
> On 09/06/2018 04:37 AM, Baolin
Hi!
> diff --git a/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx
> b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx
> new file mode 100644
> index 000..d8056d5
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx
> @@ -0,0 +1,22 @@
> +What:
Hi!
> diff --git a/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx
> b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx
> new file mode 100644
> index 000..d8056d5
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-class-led-driver-sc27xx
> @@ -0,0 +1,22 @@
> +What:
Hi Baolin,
Thank you for the patch. I really appreciate your effort.
I see one more thing I forgot to mention in the previous
review. Please take a look at my comment to pattern_set().
On 09/06/2018 04:37 AM, Baolin Wang wrote:
> This patch implements the 'pattern_set'and 'pattern_clear'
>
Hi Baolin,
Thank you for the patch. I really appreciate your effort.
I see one more thing I forgot to mention in the previous
review. Please take a look at my comment to pattern_set().
On 09/06/2018 04:37 AM, Baolin Wang wrote:
> This patch implements the 'pattern_set'and 'pattern_clear'
>
This patch implements the 'pattern_set'and 'pattern_clear'
interfaces to support SC27XX LED breathing mode.
Signed-off-by: Baolin Wang
---
Changes from v9:
- Optimize the ABI documentation file.
- Update the brightness value in hardware pattern mode.
Changes from v8:
- Optimize the ABI
This patch implements the 'pattern_set'and 'pattern_clear'
interfaces to support SC27XX LED breathing mode.
Signed-off-by: Baolin Wang
---
Changes from v9:
- Optimize the ABI documentation file.
- Update the brightness value in hardware pattern mode.
Changes from v8:
- Optimize the ABI
10 matches
Mail list logo