Re: [PATCH v13 06/18] x86/xen/time: initialize pv xen time in init_hypervisor_platform

2018-07-17 Thread Pavel Tatashin
> > + set_fixmap(FIX_PARAVIRT_BOOTMAP, xen_start_info->shared_info); > > + HYPERVISOR_shared_info = (void *)fix_to_virt(FIX_PARAVIRT_BOOTMAP); > > + > > + /* xen clock uses per-cpu vcpu_info, need to init it for boot cpu */ > > + xen_vcpu_info_reset(0); > > > I don't believe this is

Re: [PATCH v13 06/18] x86/xen/time: initialize pv xen time in init_hypervisor_platform

2018-07-17 Thread Boris Ostrovsky
On 07/11/2018 08:04 PM, Pavel Tatashin wrote: > In every hypervisor except for xen pv time ops are initialized in > init_hypervisor_platform(). > > Xen PV domains initialize time ops in x86_init.paging.pagetable_init(), > by calling xen_setup_shared_info() which is a poor design, as time is > neede

Re: [PATCH v13 06/18] x86/xen/time: initialize pv xen time in init_hypervisor_platform

2018-07-12 Thread Pavel Tatashin
> -void __ref xen_init_time_ops(void) > +void __init xen_init_time_ops(void) > { > pv_time_ops = xen_time_ops; > > @@ -542,17 +542,11 @@ void __init xen_hvm_init_time_ops(void) > return; > > if (!xen_feature(XENFEAT_hvm_safe_pvclock)) { > - printk(KERN

[PATCH v13 06/18] x86/xen/time: initialize pv xen time in init_hypervisor_platform

2018-07-11 Thread Pavel Tatashin
In every hypervisor except for xen pv time ops are initialized in init_hypervisor_platform(). Xen PV domains initialize time ops in x86_init.paging.pagetable_init(), by calling xen_setup_shared_info() which is a poor design, as time is needed prior to memory allocator. xen_setup_shared_info() is